Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ref prop to access svg html #21

Open
JediWattson opened this issue Jun 28, 2019 · 1 comment
Open

add ref prop to access svg html #21

JediWattson opened this issue Jun 28, 2019 · 1 comment

Comments

@JediWattson
Copy link

Hey I would like to use a ref to get the HTML from the avatar svg, it would help with the avataaar-generator too because that seems to use ReactDOM to get the node to download. Thanks!
@gwillz
Copy link

gwillz commented Oct 25, 2019

+1.

The only way to get the SVG (as avataaar-generator does) is with ReactDOM.findDOMNode() - which is deprecated.

The new React "concurrent mode" and "blocking mode" both don't work with findDOMNode(). It's likely it'll be dropped completely in React v17.

Happy to submit a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gwillz @JediWattson