Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Unimplemented theme support #302

Open
czaplicki opened this issue Sep 8, 2022 · 5 comments
Open

Unimplemented theme support #302

czaplicki opened this issue Sep 8, 2022 · 5 comments

Comments

@czaplicki
Copy link

czaplicki commented Sep 8, 2022

The add_theme function mentioned in the documentation isn't mentioned anywhere in code and does seem to be unimplemented.
I can go around it for now, but would be great have it ^^

Thanks in advanced Czaplicki

@ram02z
Copy link
Contributor

ram02z commented Sep 13, 2022

It was implemented at 47dc59e but removed for at 791c4b2.
Was theme support meant to be removed alongside presets @famiu ?

@famiu
Copy link
Owner

famiu commented Sep 13, 2022

It was implemented at 47dc59e but removed for at 791c4b2. Was theme support meant to be removed alongside presets @famiu ?

yes, but it seems I forgot to remove it from documentation

@mrshmllow
Copy link

mrshmllow commented Sep 23, 2022

why was it removed? what do i use now?

@nullchilly
Copy link

nullchilly commented Oct 1, 2022

@famiu Could you at least add components = function() end ?

Being a table broke the ability to change colorscheme on the fly, I currently have to add a workaround:

https://github.com/catppuccin/nvim/blob/79ae9396bda299041be70c6bb0ccee07a846a6ff/README.md?plain=1#L405-L417

@JosefLitos
Copy link

JosefLitos commented Dec 19, 2022

You should allow us then to use link within the options, instead of having to always get the hex and set fg to the hex.
It would make it also easier because you could just use the table to directly set the group.
Also I don't think there should be default highlight applied, since then SmiteshP/nvim-navic for example cannot change the color.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants