Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpplint for TravisCI builds #533

Open
alexeevdv opened this issue Aug 13, 2017 · 6 comments
Open

cpplint for TravisCI builds #533

alexeevdv opened this issue Aug 13, 2017 · 6 comments
Assignees

Comments

@alexeevdv
Copy link
Contributor

We are going to use https://github.com/cpplint/cpplint in order to make code compatible with http://google.github.io/styleguide/cppguide.html

@alexeevdv alexeevdv self-assigned this Aug 13, 2017
@phobos2077
Copy link
Contributor

Strange decision. Google's style guide is very controversial :)

@alexeevdv
Copy link
Contributor Author

There is need for some code style. And Google's one not the worst

@phobos2077
Copy link
Contributor

I thought we already had code style. What's the point reformatting all code for it? It's even documented in the wiki. Why not configure cpplint for existing rules?

@JanSimek
Copy link
Contributor

JanSimek commented Jan 5, 2020

Should be a piece of cake with this Github Action: https://github.com/marketplace/actions/action-cpp-lint

Alternatively, we could use a .editorconfig action since we already have .editorconfig

@eirnym
Copy link
Contributor

eirnym commented Dec 21, 2021

As this project started to use clang-format (based on configuration files for it), I'd suggest to add format and tidy GitHub Workflows for this. Few of them I found:

https://github.com/marketplace/actions/clang-format-check
https://github.com/marketplace/actions/clang-format-lint
https://github.com/marketplace/actions/c-code-linter-clang-tidy-and-cppcheck

@alexeevdv
Copy link
Contributor Author

clang-tidy has been added to workflow in #657
clang-format will be added as soon as .clang-format config become stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants