Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect position of doors #521

Open
phobos2077 opened this issue Apr 5, 2017 · 7 comments
Open

Incorrect position of doors #521

phobos2077 opened this issue Apr 5, 2017 · 7 comments

Comments

@phobos2077
Copy link
Contributor

phobos2077 commented Apr 5, 2017

Map: klamall
Screenshot

If you look at the doors in the north of start position, there are gaps between the doors and walls around them. Seems like some kind of offset issue.

Also noticed an offset issue with main interface panel - there is a small gap between the panel and bottom screen border. May be related somehow.

@phobos2077 phobos2077 added the bug label Apr 5, 2017
@phobos2077 phobos2077 added this to the 0.4.0 milestone Apr 5, 2017
@Zervox
Copy link
Contributor

Zervox commented Apr 6, 2017

Fixed PlayerPanel offset in my pull request, using the SetX and SetY in constructor as to make sure input works
Traced input and rendering bug to Animation offsets

both fixed in two separate pull requests.

@phobos2077
Copy link
Contributor Author

What do you mean by "input bug"?

@Zervox
Copy link
Contributor

Zervox commented Apr 7, 2017

its not just rendering that was off holding the mouse between the cracks would connect the mouse to the floors behind the door, the changes to Animation fixes that too.

@Zervox
Copy link
Contributor

Zervox commented Apr 7, 2017

@phobos2077
Copy link
Contributor Author

Damn, looks like @isage did some changes that added these offsets. We need to dig into his changes deeper and find out what exactly he did and why. Adding hacks to overcome older hacks - is a paved road to hell.

@Zervox
Copy link
Contributor

Zervox commented Apr 7, 2017

seeing as he added transparant edges might be something to do with animation for frame edges?

@phobos2077
Copy link
Contributor Author

I'm not really sure. I only know that he added outlines for objects somewhere around that period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants