-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate code for parsing INI files #515
Comments
What is the real benefit of this change? Is there any real issue? Also note that Ini::Value holds a union of various types, not just std::string so you can't trivially replace it. |
benefits: |
There are actually 2 Ini::Value classes in So the actual issue is to maybe get rid of |
city.txt parser has useful logic for getting array of properties by simple regilar expression. (example: entrance_%d) Moving this to common parser could be useful in future. |
I noticed that there is already a Parser set in Txt, toInt, toDouble and toBool, could be moved from Ini::Value into Parser as static with const std::string, replacing all Value with std::string instead.(no point having a duplicate structure for something which could be called as generics.
The text was updated successfully, but these errors were encountered: