Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faker.plant.tree and faker.plant.flower #2022

Open
matthewmayer opened this issue Apr 4, 2023 · 2 comments · May be fixed by #2126
Open

faker.plant.tree and faker.plant.flower #2022

matthewmayer opened this issue Apr 4, 2023 · 2 comments · May be fixed by #2126
Assignees
Labels
c: feature Request for new feature p: 1-normal Nothing urgent s: waiting for user interest Waiting for more users interested in this feature
Milestone

Comments

@matthewmayer
Copy link
Contributor

Clear and concise description of the problem

Similar to animal module, a plant module

I feel this would be quite useful in its own right but also as a pattern for other modules

for example it’s common in English to name street names after trees eg Oak Steet, Pine Street.

Trees and flowers are also often used as placeholder names eg naming meeting rooms, classes in a school etc.

Suggested solution

Add plant module with two methods to start with

Alternative

No response

Additional context

No response

@matthewmayer matthewmayer added c: feature Request for new feature p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision labels Apr 4, 2023
@matthewmayer matthewmayer self-assigned this Apr 4, 2023
@ST-DDT ST-DDT added s: waiting for user interest Waiting for more users interested in this feature and removed s: needs decision Needs team/maintainer decision labels Apr 6, 2023
@ST-DDT ST-DDT added this to the vFuture milestone Apr 6, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Apr 6, 2023

If you are interested in this feature please up vote the top comment, so we know what is important for our community.

@sarahtang7 sarahtang7 linked a pull request May 5, 2023 that will close this issue
@ST-DDT ST-DDT linked a pull request May 5, 2023 that will close this issue
@ST-DDT ST-DDT added s: waiting for user interest Waiting for more users interested in this feature and removed s: waiting for user interest Waiting for more users interested in this feature labels May 5, 2023
@github-actions
Copy link

github-actions bot commented May 5, 2023

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

  • If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
  • If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.

We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.

We will start the implementation based on:

  • the number of votes (:+1:) and comments
  • the relevance for the ecosystem
  • availability of alternatives and workarounds
  • and the complexity of the requested feature

We do this because:

  • There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
  • Every feature we add to faker has "costs" associated to it:
    • initial costs: design, implementation, reviews, documentation
    • running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

View more issues which are waiting for user interest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature p: 1-normal Nothing urgent s: waiting for user interest Waiting for more users interested in this feature
Projects
No open projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants