Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

knn_gpu should use raft when raft is compiled in #3382

Open
mdouze opened this issue Apr 23, 2024 · 2 comments
Open

knn_gpu should use raft when raft is compiled in #3382

mdouze opened this issue Apr 23, 2024 · 2 comments

Comments

@mdouze
Copy link
Contributor

mdouze commented Apr 23, 2024

by default use_raft is set to false, see

https://github.com/facebookresearch/faiss/blob/main/faiss/python/gpu_wrappers.py#L59

It should be set to use_raft='auto' and decide at runtime using get_compile_options().

https://github.com/facebookresearch/faiss/blob/main/faiss/gpu/GpuIndex.cu#L532

@mdouze
Copy link
Contributor Author

mdouze commented Apr 24, 2024

in fact the GpuDistanceParams.use_raft should be set to true by default when raft is used.

NB that

https://github.com/facebookresearch/faiss/blob/main/contrib/torch_utils.py#L496

does not support RAFT. Needs to be fixed as well.

@mdouze
Copy link
Contributor Author

mdouze commented Apr 24, 2024

There may be a float16 bug. Also make sure there is good test coverage for GPU torch array + raft + float16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant