Skip to content
This repository has been archived by the owner on May 1, 2023. It is now read-only.

A potential null pointer dereference bug. Please confirm, much appreicated! #681

Open
HermioneSW opened this issue Apr 8, 2020 · 1 comment

Comments

@HermioneSW
Copy link

HermioneSW commented Apr 8, 2020

Hi,

We are developing a new static analysis tool for catching bugs in Java code. Upon scanning your codebase we find the following:

In Frame.java (stetho/src/main/java/com/facebook/stetho/websocket/Frame.java) line 41, if hasMask is false then maskingKey will be assigned null when passed to MaskingHelper.unmask(maskingKey, payloadData, 0, (int)payloadLen) the expression key[index++ % key.length] at line 14 in MaskingHelper.java will trigger a null pointer dereference.

Would you please take a look and confirm this is indeed a bug? Thanks a million!!!

@HermioneSW
Copy link
Author

Hi, can anyone please take a look at the issue and confirm this is indeed a bug? Thanks a million!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant