This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
[WIP] Remove in property checking for ObjectValues - fixes 2510
#2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/methods/typedarray.js
Outdated
| O instanceof ObjectValue && "$ViewedArrayBuffer" in O, | ||
| "O is an Object that has a [[ViewedArrayBuffer]] internal slot" | ||
| ); | ||
| // Update: [[ViewedArrayBuffer]] will always be an internal slot, see #2512 |
There was a problem hiding this comment.
I don't understand this comment.
|
I'll take another look at this PR next week. @sebmarkbage would be good if you could see what I'm doing wrong here, it seems defining these properties on the |
trueadm
changed the title
in property checking for ObjectValues - fixes 2510in property checking for ObjectValues - fixes 2510
trueadm
added
the
WIP
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: fixes potential issues with our Babel 7 transform internally
This PR is to address the issues outlined in #2510 in regards to
ObjectValueand the usage through the Prepack codebase for where we useinto check for property existence. This changes that usage to explicitundefinedchecks due to our internal Babel transform compiling to output that is not compatible withinchecks. Fixes #2510