{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":257259929,"defaultBranch":"main","name":"time","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-04-20T11:29:32.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1713539195.0","currentOid":""},"activityList":{"items":[{"before":"b56da860b6c1a2f133fd2cdd9a459cf29b226ec0","after":"fa89cc57589115d1d77ec2c62fb32b7e273b4c54","ref":"refs/heads/main","pushedAt":"2024-05-10T11:37:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"delay startup option\n\nSummary:\nHosts coming from reboot have a very high offset. sptp will correct it eventually, but we shouldn't even provide this info to the users.\nInstead, we can delay start of fbclock sidecar until clock is fully corrected which is usually ~2-5 minutes.\nAt the same time this change shouldn't impact regular restarts which is why we can link it to the system uptime.\n\nReviewed By: vvfedorenko\n\nDifferential Revision: D57165813\n\nfbshipit-source-id: f02c742ad5aff984212d0bf39f41e9d7243843e0","shortMessageHtmlLink":"delay startup option"}},{"before":"1e06781511478bb4084e2c9493f0dc68d7d9ef97","after":"b56da860b6c1a2f133fd2cdd9a459cf29b226ec0","ref":"refs/heads/main","pushedAt":"2024-05-01T09:44:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"filtered counter\n\nSummary:\nReport to ODS number of filtered offset.\nThis will help to identify hosts with NIC/Network problems\n\nReviewed By: abulimov\n\nDifferential Revision: D56765873\n\nfbshipit-source-id: 5420a7f3731ada517f5f6a319c54a4e696f46c92","shortMessageHtmlLink":"filtered counter"}},{"before":"32516f7980b37a78ee32324e6304f53fc53d19d7","after":"1e06781511478bb4084e2c9493f0dc68d7d9ef97","ref":"refs/heads/main","pushedAt":"2024-04-30T16:47:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"unify stats collection\n\nSummary:\nThis diff unifies the stats collection within `sptp` by using pre-defined counters instead of a map with free form counters. Why?\n* Better consistency. GM metrics already have predefined counters. Other counters plugged as a map next to it. This diff even removes a need for separate routine started in `main.go`. Same \"style\" is also used in `ntpresponder` and `ptp4u`.\n* Be explicit - random counters don't appear out because of a random string introduced without tests.\n* Easier to manage - accessing/modifying from any place in the code without specifying full counter path. No typos, no long strings.\n* Less dynamic allocations = less GC triggers https://pxl.cl/4MFnq\n\nReviewed By: abulimov\n\nDifferential Revision: D56754543\n\nfbshipit-source-id: 237f0d6411e285040ccc01a89ee1dba541f26ee6","shortMessageHtmlLink":"unify stats collection"}},{"before":"35f3e1e2950eeec0a6fc68246b8edb3357f74ae1","after":"32516f7980b37a78ee32324e6304f53fc53d19d7","ref":"refs/heads/main","pushedAt":"2024-04-29T14:30:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove unused sequence number from mdata struct\n\nSummary: Sequence number is used as a key of the mData map. We don't need it inside the struct itself and it's not actually used\n\nReviewed By: abulimov\n\nDifferential Revision: D56704209\n\nfbshipit-source-id: e014f6734f37fabcb1fcfa71d699bcdc62d4e024","shortMessageHtmlLink":"remove unused sequence number from mdata struct"}},{"before":"f60b0e0fdd30c4f3986c860b109dc6a7ec159a3f","after":"35f3e1e2950eeec0a6fc68246b8edb3357f74ae1","ref":"refs/heads/main","pushedAt":"2024-04-26T14:58:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"use \"target\" var as a device name\n\nSummary: Simplify logic a little bit\n\nReviewed By: abulimov\n\nDifferential Revision: D56633054\n\nfbshipit-source-id: 8a51f441014b2c89ece283db0153f076c297a187","shortMessageHtmlLink":"use \"target\" var as a device name"}},{"before":"b0fe11f86ec0228d5bd1cd078f4073717d2e038f","after":"f60b0e0fdd30c4f3986c860b109dc6a7ec159a3f","ref":"refs/heads/main","pushedAt":"2024-04-26T12:31:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"use --device everywhere\n\nSummary: Use `--device` universally everywhere instead of `--target`/`--source`.\n\nReviewed By: deathowl\n\nDifferential Revision: D56629153\n\nfbshipit-source-id: c06c74c3496364c58857cf046799900101d050ea","shortMessageHtmlLink":"use --device everywhere"}},{"before":"b998b76a58ff90ac65016d7b2f2f01dd51fd534e","after":"b0fe11f86ec0228d5bd1cd078f4073717d2e038f","ref":"refs/heads/main","pushedAt":"2024-04-24T17:16:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"rename most source/target to device (#352)\n\nSummary:\nPull Request resolved: https://github.com/facebook/time/pull/352\n\nSick and tired of remembering which one is which. Let's just use \"device\".\n\nReviewed By: abulimov\n\nDifferential Revision: D56520857\n\nfbshipit-source-id: 0f34f6d23bc496c3534dc12a97db347850d63058","shortMessageHtmlLink":"rename most source/target to device (#352)"}},{"before":"dd74bec38256a95c47cf8263bfe715bb7e2f18f0","after":"b998b76a58ff90ac65016d7b2f2f01dd51fd534e","ref":"refs/heads/main","pushedAt":"2024-04-23T15:31:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"use RX only timestamp in ntp/responder (#350)\n\nSummary:\nPull Request resolved: https://github.com/facebook/time/pull/350\n\nResponder doesn't need TX timestamps which only slows it down.\nInstead, make Timestamp a type\n\nReviewed By: abulimov, yarikk\n\nDifferential Revision: D56465553\n\nfbshipit-source-id: e160e1773ffff08667bcc35fd3624b4114db43a7","shortMessageHtmlLink":"use RX only timestamp in ntp/responder (#350)"}},{"before":"f9273157d7f92e1068acfe2f540cc627749e5757","after":"dd74bec38256a95c47cf8263bfe715bb7e2f18f0","ref":"refs/heads/main","pushedAt":"2024-04-23T15:00:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Set go version from 1.18 to 1.21 (#351)\n\nSummary:\n```\ngo mod edit -go=1.21\n```\n\nPull Request resolved: https://github.com/facebook/time/pull/351\n\nReviewed By: abulimov\n\nDifferential Revision: D56470776\n\nPulled By: leoleovich\n\nfbshipit-source-id: c4c97fe99c91aa2b09e17db844885ad9d9e7b8c7","shortMessageHtmlLink":"Set go version from 1.18 to 1.21 (#351)"}},{"before":"52e5f6bd4f98481d7a7eefea7343bd13bb54bd8d","after":"24ee85f2c920b73205360f59fbc779718502a5af","ref":"refs/heads/go_1.22","pushedAt":"2024-04-23T14:27:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"leoleovich","name":"Oleg Obleukhov","path":"/leoleovich","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4749052?s=80&v=4"},"commit":{"message":"Set go version from 1.18 to 1.21","shortMessageHtmlLink":"Set go version from 1.18 to 1.21"}},{"before":"eff7579c3b42583c42880c76af56a198b68c7fcc","after":"52e5f6bd4f98481d7a7eefea7343bd13bb54bd8d","ref":"refs/heads/go_1.22","pushedAt":"2024-04-23T14:26:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"leoleovich","name":"Oleg Obleukhov","path":"/leoleovich","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4749052?s=80&v=4"},"commit":{"message":"Set go version from 1.18 to 1.22","shortMessageHtmlLink":"Set go version from 1.18 to 1.22"}},{"before":"caea3837b640d023fe03f37886f9a5e4fbc4fb80","after":"eff7579c3b42583c42880c76af56a198b68c7fcc","ref":"refs/heads/go_1.22","pushedAt":"2024-04-23T14:10:02.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"leoleovich","name":"Oleg Obleukhov","path":"/leoleovich","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4749052?s=80&v=4"},"commit":{"message":"Set go version from 1.18 to 1.22","shortMessageHtmlLink":"Set go version from 1.18 to 1.22"}},{"before":null,"after":"caea3837b640d023fe03f37886f9a5e4fbc4fb80","ref":"refs/heads/go_1.22","pushedAt":"2024-04-23T14:05:05.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"leoleovich","name":"Oleg Obleukhov","path":"/leoleovich","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4749052?s=80&v=4"},"commit":{"message":"Set go version from 1.18 to 1.22","shortMessageHtmlLink":"Set go version from 1.18 to 1.22"}},{"before":"e4f24e18edf7f30bee04eac28637027655996284","after":"f9273157d7f92e1068acfe2f540cc627749e5757","ref":"refs/heads/main","pushedAt":"2024-04-23T13:56:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"improve test timeouts (#349)\n\nSummary:\nPull Request resolved: https://github.com/facebook/time/pull/349\n\nUnify and extend test timeouts so we don't fail randomly on slow runs.\n\nReviewed By: leoleovich\n\nDifferential Revision: D56469346\n\nfbshipit-source-id: 04659a4e24151d3a6c7485bae2f69feacaa0d6db","shortMessageHtmlLink":"improve test timeouts (#349)"}},{"before":"ed698debb9041214b2f47dfd9cbc6faf1f8d94ac","after":"e4f24e18edf7f30bee04eac28637027655996284","ref":"refs/heads/main","pushedAt":"2024-04-19T20:14:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"bring back hardware timestamps reference\n\nSummary: Produly mention that NTP responder supports hardware timestamps\n\nReviewed By: pmazzini\n\nDifferential Revision: D56367466\n\nfbshipit-source-id: fd08544d20ca38f80cefff50ee103b4ee2c8e168","shortMessageHtmlLink":"bring back hardware timestamps reference"}},{"before":"2be3b62fd6a294349521a338c0542955ae2d6c12","after":"ed698debb9041214b2f47dfd9cbc6faf1f8d94ac","ref":"refs/heads/main","pushedAt":"2024-04-19T19:39:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"use EnableTimestamps library (#348)\n\nSummary:\nPull Request resolved: https://github.com/facebook/time/pull/348\n\nUse the x-platform timestamp wrapper in PTP components as well and avoid code duplication.\nRemove autodetection as well because it usually never a good idea.\n\nReviewed By: t3lurid3\n\nDifferential Revision: D56357939\n\nfbshipit-source-id: 3ad54e1bdaa1fa1b02680d4830c4725deeca5f03","shortMessageHtmlLink":"use EnableTimestamps library (#348)"}},{"before":"48db0517d7bb51d7c1d23204af5719708b5b3edd","after":"2be3b62fd6a294349521a338c0542955ae2d6c12","ref":"refs/heads/main","pushedAt":"2024-04-19T16:11:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"support hardware timestamps (#346)\n\nSummary:\nPull Request resolved: https://github.com/facebook/time/pull/346\n\nAdd an option to enable hardware timestamps on ntp responder.\nDefault is software (same behaviour).\nApart from enabling hardware timestamper (which is only supported on Linux) we also run periodic PHC-SYS measurements\n\nReviewed By: pmazzini\n\nDifferential Revision: D56255701\n\nfbshipit-source-id: 56d83334f93a53f58a02efabb96ef741b914bd9f","shortMessageHtmlLink":"support hardware timestamps (#346)"}},{"before":"2de83640395b046121cca40c17ea6e0e877d48df","after":null,"ref":"refs/heads/bump","pushedAt":"2024-04-19T15:06:35.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"pmazzini","name":"Pablo Mazzini","path":"/pmazzini","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13187595?s=80&v=4"}},{"before":"0d7d0698529ece58709552ad595ea38409078d74","after":"48db0517d7bb51d7c1d23204af5719708b5b3edd","ref":"refs/heads/main","pushedAt":"2024-04-19T15:05:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Bump golang.org/x/net from 0.17.0 to 0.23.0 (#347)\n\nSummary: Pull Request resolved: https://github.com/facebook/time/pull/347\n\nReviewed By: leoleovich\n\nDifferential Revision: D56355667\n\nfbshipit-source-id: 9837be62b181b58956ad601c1d246455eb3d7f78","shortMessageHtmlLink":"Bump golang.org/x/net from 0.17.0 to 0.23.0 (#347)"}},{"before":"495c13dd0cb45f2caf308cd96e690fbd7e96f132","after":null,"ref":"refs/heads/cobra_upgrade","pushedAt":"2024-04-19T15:04:39.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"pmazzini","name":"Pablo Mazzini","path":"/pmazzini","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13187595?s=80&v=4"}},{"before":"f3884b8e8d2d5deb15bf64d4a34c473e2220981b","after":null,"ref":"refs/heads/clock_32bit","pushedAt":"2024-04-19T15:04:37.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"pmazzini","name":"Pablo Mazzini","path":"/pmazzini","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13187595?s=80&v=4"}},{"before":null,"after":"2de83640395b046121cca40c17ea6e0e877d48df","ref":"refs/heads/bump","pushedAt":"2024-04-19T14:35:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"pmazzini","name":"Pablo Mazzini","path":"/pmazzini","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/13187595?s=80&v=4"},"commit":{"message":"Bump golang.org/x/net from 0.17.0 to 0.23.0","shortMessageHtmlLink":"Bump golang.org/x/net from 0.17.0 to 0.23.0"}},{"before":"b1396fbfaf54847781e55dd0423112a9e0124776","after":"0d7d0698529ece58709552ad595ea38409078d74","ref":"refs/heads/main","pushedAt":"2024-04-18T13:36:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"improve config structure (#345)\n\nSummary:\nPull Request resolved: https://github.com/facebook/time/pull/345\n\nImprove config structure to allow easier introduction of new options.\n\nReviewed By: abulimov\n\nDifferential Revision: D56253896\n\nfbshipit-source-id: 35f4fa29eed8c75aa2b6b20609cce3e4656bf276","shortMessageHtmlLink":"improve config structure (#345)"}},{"before":"e712c75e145972daf0af03daa95ac4a0b8f054aa","after":"b1396fbfaf54847781e55dd0423112a9e0124776","ref":"refs/heads/main","pushedAt":"2024-04-17T15:34:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"replace go get with go install in README (#344)\n\nSummary:\nPull Request resolved: https://github.com/facebook/time/pull/344\n\ngo get is no more, let's modernise\n\nReviewed By: pmazzini\n\nDifferential Revision: D56244379\n\nfbshipit-source-id: 4caab1c78751550f2757ec46877f3d84ec4dbc6a","shortMessageHtmlLink":"replace go get with go install in README (#344)"}},{"before":"930f6483e22471bd9c7eb0ea23c0b4d67cde1c49","after":null,"ref":"refs/heads/leoleovich-patch-3","pushedAt":"2024-04-17T15:09:09.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"leoleovich","name":"Oleg Obleukhov","path":"/leoleovich","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4749052?s=80&v=4"}},{"before":"2f602b0ebb7af08cc45032541297586f21e45c70","after":null,"ref":"refs/heads/testify_upgrade","pushedAt":"2024-04-17T15:09:08.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"leoleovich","name":"Oleg Obleukhov","path":"/leoleovich","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4749052?s=80&v=4"}},{"before":"6f0ef4a7eeaf922be6dfc153bc67fdf53b531ad3","after":null,"ref":"refs/heads/leoleovich-patch-1","pushedAt":"2024-04-17T15:09:06.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"leoleovich","name":"Oleg Obleukhov","path":"/leoleovich","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4749052?s=80&v=4"}},{"before":"cebef2f4785ac3bde9399ce92a2aaa75cf6655ea","after":null,"ref":"refs/heads/go_sum_fix","pushedAt":"2024-04-17T15:09:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"leoleovich","name":"Oleg Obleukhov","path":"/leoleovich","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4749052?s=80&v=4"}},{"before":"83a42943c3d72e02328c881fbce0b713a9391bae","after":"e712c75e145972daf0af03daa95ac4a0b8f054aa","ref":"refs/heads/main","pushedAt":"2024-04-16T17:56:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Ignore EOPNOTSUPP for SIOCGHWTSTAMP (#343)\n\nSummary:\nPull Request resolved: https://github.com/facebook/time/pull/343\n\nSome hardware doesn't have non-distructive SIOCGHWTSTAMP but can still do hardware timestamping. It's mostly about HW having ext PHY module. Let's ignore this error and allow setting values\n\nReviewed By: leoleovich\n\nDifferential Revision: D56185343\n\nfbshipit-source-id: e906af27db7e3e0eb0e1b08df41dbc19490bad98","shortMessageHtmlLink":"Ignore EOPNOTSUPP for SIOCGHWTSTAMP (#343)"}},{"before":"7a8c86b35ada8760fc1fbf746d974b052d2ac2f2","after":"83a42943c3d72e02328c881fbce0b713a9391bae","ref":"refs/heads/main","pushedAt":"2024-04-15T13:10:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"don't return error on certificate match (#340)\n\nSummary:\nPull Request resolved: https://github.com/facebook/time/pull/340\n\nReturn nil (all good) if provisioned certificate is matching certificate from the system\n\nReviewed By: abulimov, vvfedorenko\n\nDifferential Revision: D56135420\n\nfbshipit-source-id: d47d5c939b66b4b8db85f55ac66e750480ae667c","shortMessageHtmlLink":"don't return error on certificate match (#340)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAERoOWVAA","startCursor":null,"endCursor":null}},"title":"Activity ยท facebook/time"}