Don't force en_US.utf-8 as locale as it mgiht not exist. #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glibc does not generate all combinations of locales by default, and Python fails when requesting to enforce a locale that does not exist. Since the extension is not caring for the translation chosen, but rather only trying to enforce UTF-8 support, use the C.UTF-8 locale which is guaranteed to exist as per https://www.gnu.org/software/libc/manual/html_node/Choosing-Locale.html Fixes facebook#814 where VSCode would intermittently be unable to identify a valid Sapling checkout and/or pull from a repository.
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks for the PR, but we decided to go in another way with a3608fd . Sorry for the late notice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't force en_US.utf-8 as locale as it mgiht not exist.
glibc does not generate all combinations of locales by default, and Python
fails when requesting to enforce a locale that does not exist.
Since the extension is not caring for the translation chosen, but rather
only trying to enforce UTF-8 support, use the C.UTF-8 locale which is
guaranteed to exist as per https://www.gnu.org/software/libc/manual/html_node/Choosing-Locale.html
Fixes #814 where VSCode would intermittently be unable to identify
a valid Sapling checkout and/or pull from a repository.