{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":54664770,"defaultBranch":"main","name":"redex","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2016-03-24T18:26:35.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1699985801.0","currentOid":""},"activityList":{"items":[{"before":"4f4010d63e661736a3b58119448a7f48b9badba5","after":"85ebd403e8b0db782d9c7222f87128f1894da0c5","ref":"refs/heads/main","pushedAt":"2024-05-13T18:10:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Attempting to fix OSS build (#860)\n\nSummary:\nPull Request resolved: https://github.com/facebook/redex/pull/860\n\nI don't understand what has changed, but an include might be missing.\n\nReviewed By: beicy\n\nDifferential Revision: D57237245\n\nfbshipit-source-id: 0f16c3274a3f5c91a3345f9f1cc3e5743346e841","shortMessageHtmlLink":"Attempting to fix OSS build (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2290535820\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/redex/issues/860\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/redex/pull/860/hovercard\" href=\"https://github.com/facebook/redex/pull/860\">#860</a>)"}},{"before":"3f8deee1e39ef21d11b24e8e516c3b4585ccb856","after":"801d165175c3ec3af2a0dbcfadfb714d57223138","ref":"refs/heads/gh-pages","pushedAt":"2024-05-13T16:31:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 4f4010d63e661736a3b58119448a7f48b9badba5","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebook/redex/commit/4f4010d63e661736a3b58119448a7f48b9badba5/hovercard\" href=\"https://github.com/facebook/redex/commit/4f4010d63e661736a3b58119448a7f48b9badba5\"><tt>4f4010d</tt></a>"}},{"before":"f5d59bd4e125807d031bfa1e87a0463c44e6b9e1","after":"4f4010d63e661736a3b58119448a7f48b9badba5","ref":"refs/heads/main","pushedAt":"2024-05-13T16:30:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Make cross-dex-penalty multipliers into floats\n\nSummary:\nThis allows for more granular configuration.\nThis is a behavior-preserving change.\n\nReviewed By: wsanville\n\nDifferential Revision: D57168979\n\nfbshipit-source-id: 66b4cfed0c255e49a1144ad2644d297cd976f045","shortMessageHtmlLink":"Make cross-dex-penalty multipliers into floats"}},{"before":"12def00bf0703866c9dd19a976139cd61c8b3aad","after":"3f8deee1e39ef21d11b24e8e516c3b4585ccb856","ref":"refs/heads/gh-pages","pushedAt":"2024-05-10T22:47:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: f5d59bd4e125807d031bfa1e87a0463c44e6b9e1","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebook/redex/commit/f5d59bd4e125807d031bfa1e87a0463c44e6b9e1/hovercard\" href=\"https://github.com/facebook/redex/commit/f5d59bd4e125807d031bfa1e87a0463c44e6b9e1\"><tt>f5d59bd</tt></a>"}},{"before":"a93afe1463f5e3fb705f2e79fd778e98374608f5","after":"f5d59bd4e125807d031bfa1e87a0463c44e6b9e1","ref":"refs/heads/main","pushedAt":"2024-05-10T22:46:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"More validation\n\nReviewed By: ssj933\n\nDifferential Revision: D57176819\n\nfbshipit-source-id: dbe31f4464a57aff7b011c38ab5b523b0c0d33e8","shortMessageHtmlLink":"More validation"}},{"before":"7dc4f76fe6ac05d58e7b53c7ccb17b0624123fb8","after":"12def00bf0703866c9dd19a976139cd61c8b3aad","ref":"refs/heads/gh-pages","pushedAt":"2024-05-09T01:38:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: a93afe1463f5e3fb705f2e79fd778e98374608f5","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebook/redex/commit/a93afe1463f5e3fb705f2e79fd778e98374608f5/hovercard\" href=\"https://github.com/facebook/redex/commit/a93afe1463f5e3fb705f2e79fd778e98374608f5\"><tt>a93afe1</tt></a>"}},{"before":"81a132ab5509c1c05363e42367efeba41757820a","after":"a93afe1463f5e3fb705f2e79fd778e98374608f5","ref":"refs/heads/main","pushedAt":"2024-05-09T01:38:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add flag to toggle reshuffle\n\nSummary: as title, no behavior change.\n\nReviewed By: thezhangwei\n\nDifferential Revision: D57133577\n\nfbshipit-source-id: f9cdc993dc91ef5e7e3236e9f1a70b295c5d93b8","shortMessageHtmlLink":"Add flag to toggle reshuffle"}},{"before":"c0720b02acac619482d2ad634c42ccd8edbb5a82","after":"7dc4f76fe6ac05d58e7b53c7ccb17b0624123fb8","ref":"refs/heads/gh-pages","pushedAt":"2024-05-09T00:14:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 81a132ab5509c1c05363e42367efeba41757820a","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebook/redex/commit/81a132ab5509c1c05363e42367efeba41757820a/hovercard\" href=\"https://github.com/facebook/redex/commit/81a132ab5509c1c05363e42367efeba41757820a\"><tt>81a132a</tt></a>"}},{"before":"5e1407807168304d7765c63097b7566b190ead66","after":"81a132ab5509c1c05363e42367efeba41757820a","ref":"refs/heads/main","pushedAt":"2024-05-09T00:14:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"More validation\n\nReviewed By: thezhangwei\n\nDifferential Revision: D57128631\n\nfbshipit-source-id: ff2a2b4aee4645db3482c28c997940a3d8421f73","shortMessageHtmlLink":"More validation"}},{"before":"421956484d807398728871481ce5af4abdfe5531","after":"c0720b02acac619482d2ad634c42ccd8edbb5a82","ref":"refs/heads/gh-pages","pushedAt":"2024-05-08T17:03:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 5e1407807168304d7765c63097b7566b190ead66","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebook/redex/commit/5e1407807168304d7765c63097b7566b190ead66/hovercard\" href=\"https://github.com/facebook/redex/commit/5e1407807168304d7765c63097b7566b190ead66\"><tt>5e14078</tt></a>"}},{"before":"fd22985e5cf067eac514fa540cb3c17886682e49","after":"5e1407807168304d7765c63097b7566b190ead66","ref":"refs/heads/main","pushedAt":"2024-05-08T17:03:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove destructor\n\nSummary:\nThe destructor used to apply scope-wide changes, a quite heavy-weight operation, possibly exception throwing.\nThis could be surprising, and also made the Linter really unhappy.\nThis formerly implicit behavior is now made explicit via a `flush` function.\n\nThis is a behavior-preserving change.\n\nReviewed By: thezhangwei\n\nDifferential Revision: D57064529\n\nfbshipit-source-id: 7013853d80994c5be062e5ee834ed106f4a4e03a","shortMessageHtmlLink":"Remove destructor"}},{"before":"8875737979a535581545a4cde1a044f5ef45b476","after":"7d7cca157a18240537bf07bc772611159a8ea0c9","ref":"refs/heads/stable","pushedAt":"2024-05-07T19:28:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Promote D54130542 and D57007595 to staging and stable\n\nSummary: Promote D54130542 and D57007595 to staging and stable\n\nReviewed By: jimmycFB\n\nDifferential Revision: D57017110\n\nfbshipit-source-id: 0f7326d67b5e763a52b253dba05d53a8d4268a62","shortMessageHtmlLink":"Promote D54130542 and D57007595 to staging and stable"}},{"before":"cc4ed483dc1ad30037599188c89404f98e31815c","after":"421956484d807398728871481ce5af4abdfe5531","ref":"refs/heads/gh-pages","pushedAt":"2024-05-07T18:24:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: fd22985e5cf067eac514fa540cb3c17886682e49","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebook/redex/commit/fd22985e5cf067eac514fa540cb3c17886682e49/hovercard\" href=\"https://github.com/facebook/redex/commit/fd22985e5cf067eac514fa540cb3c17886682e49\"><tt>fd22985</tt></a>"}},{"before":"fc6faa19589062d5a94bb3faf5b4d058317f820a","after":"fd22985e5cf067eac514fa540cb3c17886682e49","ref":"refs/heads/main","pushedAt":"2024-05-07T18:23:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add option to configure a multiplier for different kinds of unused args\n\nSummary: The default is always a multiplier of 1, so this is a behavior-preserving change.\n\nReviewed By: beicy\n\nDifferential Revision: D57005516\n\nfbshipit-source-id: f67421702b647d7aa5c28009c4fc126a2226ce8c","shortMessageHtmlLink":"Add option to configure a multiplier for different kinds of unused args"}},{"before":"dc4606b1744879f52f7f945f0bf6dfc21172cd87","after":"cc4ed483dc1ad30037599188c89404f98e31815c","ref":"refs/heads/gh-pages","pushedAt":"2024-05-07T17:47:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: fc6faa19589062d5a94bb3faf5b4d058317f820a","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebook/redex/commit/fc6faa19589062d5a94bb3faf5b4d058317f820a/hovercard\" href=\"https://github.com/facebook/redex/commit/fc6faa19589062d5a94bb3faf5b4d058317f820a\"><tt>fc6faa1</tt></a>"}},{"before":"68342f9b257b5812f68900584ced3865b5116b46","after":"fc6faa19589062d5a94bb3faf5b4d058317f820a","ref":"refs/heads/main","pushedAt":"2024-05-07T17:47:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Extend ClassChecker to find erroneously overriding methods\n\nSummary: This attempts to point out when a final method has been accidentally overridden in a sub class, following the details at https://docs.oracle.com/javase/specs/jvms/se8/html/jvms-5.html#jvms-5.4.5\n\nReviewed By: NTillmann\n\nDifferential Revision: D55454156\n\nfbshipit-source-id: c9b3133c1a5d9797b1ef3111aeabb1d2b6d6bbc7","shortMessageHtmlLink":"Extend ClassChecker to find erroneously overriding methods"}},{"before":"cdee786a23b71bc156e0f74bbdfd381fedb63ec2","after":"8875737979a535581545a4cde1a044f5ef45b476","ref":"refs/heads/stable","pushedAt":"2024-05-07T12:05:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Retire OatmealQuickening/PostLowering\n\nSummary: Unused.\n\nDifferential Revision: D56930278\n\nfbshipit-source-id: e2177d30479c02ae53c10cb61ab3601aa2286efb","shortMessageHtmlLink":"Retire OatmealQuickening/PostLowering"}},{"before":"74aaaf3f925f0c576d004d3c841b9d8b5fe90996","after":"dc4606b1744879f52f7f945f0bf6dfc21172cd87","ref":"refs/heads/gh-pages","pushedAt":"2024-05-07T11:59:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 68342f9b257b5812f68900584ced3865b5116b46","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebook/redex/commit/68342f9b257b5812f68900584ced3865b5116b46/hovercard\" href=\"https://github.com/facebook/redex/commit/68342f9b257b5812f68900584ced3865b5116b46\"><tt>68342f9</tt></a>"}},{"before":"eb4ce8bdbd85b93633ca295907668cd2495b4d56","after":"68342f9b257b5812f68900584ced3865b5116b46","ref":"refs/heads/main","pushedAt":"2024-05-07T11:58:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Retire OatmealQuickening/PostLowering\n\nSummary: Unused.\n\nDifferential Revision: D56930278\n\nfbshipit-source-id: e2177d30479c02ae53c10cb61ab3601aa2286efb","shortMessageHtmlLink":"Retire OatmealQuickening/PostLowering"}},{"before":"5c032f7a02f944ebb5c217fb99d0e3d758a376c0","after":"74aaaf3f925f0c576d004d3c841b9d8b5fe90996","ref":"refs/heads/gh-pages","pushedAt":"2024-05-06T20:51:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: eb4ce8bdbd85b93633ca295907668cd2495b4d56","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebook/redex/commit/eb4ce8bdbd85b93633ca295907668cd2495b4d56/hovercard\" href=\"https://github.com/facebook/redex/commit/eb4ce8bdbd85b93633ca295907668cd2495b4d56\"><tt>eb4ce8b</tt></a>"}},{"before":"06a7d9d5d8b2912eb2a9938404d27cc8192d1038","after":"eb4ce8bdbd85b93633ca295907668cd2495b4d56","ref":"refs/heads/main","pushedAt":"2024-05-06T20:51:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove debug check for finding classes under other res directories\n\nSummary:\nThis method scans xml files for strings that could be possible Java class names. Long ago, a perf optimization was put in to limit the directories searched to exclude things that would be unlikely to reference dex code, like color or vector drawables.\n\nIn debug mode, there is an assert to run this logic twice, the second time with no directory filters and assert the size match. With the more broad searching done by D56372640, searching the drawable directory reports more strings.\n\nThese are not strings that are class names (strings like P1229962922 from P1229963360 are not classes) but nevertheless the assert was firing because at this level of the API, it doesn't check that these strings are actual types.\n\nI think that we can get rid of this assert since D56372640 will put us in a better position to find more real class names anyways.\n\nReviewed By: jimmycFB\n\nDifferential Revision: D56961260\n\nfbshipit-source-id: bc1920645da93f52162c8a4c5295445d6b52fb1a","shortMessageHtmlLink":"Remove debug check for finding classes under other res directories"}},{"before":"dfbc18d072437e581533e5c17006e727c036120f","after":"5c032f7a02f944ebb5c217fb99d0e3d758a376c0","ref":"refs/heads/gh-pages","pushedAt":"2024-05-06T20:31:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 06a7d9d5d8b2912eb2a9938404d27cc8192d1038","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebook/redex/commit/06a7d9d5d8b2912eb2a9938404d27cc8192d1038/hovercard\" href=\"https://github.com/facebook/redex/commit/06a7d9d5d8b2912eb2a9938404d27cc8192d1038\"><tt>06a7d9d</tt></a>"}},{"before":"18bf461d1fb820e18158eb8c024e85a6cece3a38","after":"06a7d9d5d8b2912eb2a9938404d27cc8192d1038","ref":"refs/heads/main","pushedAt":"2024-05-06T20:30:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add fewer source blocks\n\nSummary: If the split-off block already has a source block in the beginning, don't add another synthetic source block\n\nReviewed By: jimmycFB\n\nDifferential Revision: D57007595\n\nfbshipit-source-id: 14c99ddd90a61980faa4fd6b1aded62788babae9","shortMessageHtmlLink":"Add fewer source blocks"}},{"before":"64034445e2e88814fc6a6318a63dc12239bf7da5","after":"dfbc18d072437e581533e5c17006e727c036120f","ref":"refs/heads/gh-pages","pushedAt":"2024-05-03T22:37:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 18bf461d1fb820e18158eb8c024e85a6cece3a38","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebook/redex/commit/18bf461d1fb820e18158eb8c024e85a6cece3a38/hovercard\" href=\"https://github.com/facebook/redex/commit/18bf461d1fb820e18158eb8c024e85a6cece3a38\"><tt>18bf461</tt></a>"}},{"before":"8ca75d7f22b17e8ebd7aa95efddb091de29b4af5","after":"18bf461d1fb820e18158eb8c024e85a6cece3a38","ref":"refs/heads/main","pushedAt":"2024-05-03T22:37:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Reorganize functions for checking Java identifiers (#859)\n\nSummary:\nPull Request resolved: https://github.com/facebook/redex/pull/859\n\nI made the misguided choice of refactoring and reusing some methods from ProguardLexer.cpp, and broke the build on Windows for a reason I cannot understand (`TokenType` enum values in ProguardLexer.h somehow were not parsed as valid anymore???? Dunno).\n\nRevert that part of the change, and instead move the useful methods from ProguardLexer to the `java_names` namespace in DexUtil.h.\n\nReviewed By: thezhangwei\n\nDifferential Revision: D56921682\n\nfbshipit-source-id: bd27c05e66124619c2dff50d418ac447384f7359","shortMessageHtmlLink":"Reorganize functions for checking Java identifiers (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2276965730\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/redex/issues/859\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/redex/pull/859/hovercard\" href=\"https://github.com/facebook/redex/pull/859\">#859</a>)"}},{"before":"323c3ac7bda05d17aaa81fa9607aa24f8d79207e","after":"cdee786a23b71bc156e0f74bbdfd381fedb63ec2","ref":"refs/heads/stable","pushedAt":"2024-05-03T20:13:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Promote D56603421 to stable and staging\n\nSummary: Promote D56603421 to stable and staging to enable checker changes on converted enums\n\nReviewed By: thezhangwei\n\nDifferential Revision: D56943785\n\nfbshipit-source-id: 6d08430191e31488a4926b45687ffe5f05182100","shortMessageHtmlLink":"Promote D56603421 to stable and staging"}},{"before":"53b7b18986972b73884d46768dc48702a5f23447","after":"64034445e2e88814fc6a6318a63dc12239bf7da5","ref":"refs/heads/gh-pages","pushedAt":"2024-05-03T04:26:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 8ca75d7f22b17e8ebd7aa95efddb091de29b4af5","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebook/redex/commit/8ca75d7f22b17e8ebd7aa95efddb091de29b4af5/hovercard\" href=\"https://github.com/facebook/redex/commit/8ca75d7f22b17e8ebd7aa95efddb091de29b4af5\"><tt>8ca75d7</tt></a>"}},{"before":"c126ee1aa312afd11a1ad3b2a6670ceb15b8639b","after":"8ca75d7f22b17e8ebd7aa95efddb091de29b4af5","ref":"refs/heads/main","pushedAt":"2024-05-03T04:25:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add mergeability-aware InterDexReshuffle service in IDCM\n\nReviewed By: ShatianWang\n\nDifferential Revision: D56842734\n\nfbshipit-source-id: d6e9badf0db0c6a9259296e313b04c38af7ea836","shortMessageHtmlLink":"Add mergeability-aware InterDexReshuffle service in IDCM"}},{"before":"5ce3b2a07e560db368bb353cd13bc5c81c751068","after":"c126ee1aa312afd11a1ad3b2a6670ceb15b8639b","ref":"refs/heads/main","pushedAt":"2024-05-02T21:38:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"More exact usage of merging model for method deduping\n\nSummary:\nPreviously, DexLimitsChecker crashed due to mref usage exceeding dex limits, both after the mergeability-aware InterDexReshufflePass (MAReshuffle) and the IntraDexClassMergingPass (IDCM).\n\nIt is expected that the limit is exceeded after MAReshuffle because it accounts for the mref deduping that will happen in the subsequent IDCM.\n\nThe limit was exceeded after the IDCM because our approximation of mref deduping was inaccurate. During the process of debugging to identify the gap between our approximation in MAReshuffle and what actually happened in IDCM, we realized that the following contributed to at least 90% of the gap, closing which could bring down the maximum number of mrefs exceeding limit per dex from ~2100 to ~150:\n\n- MAReshuffle does not account for the `excluded_types` used by IDCM\n- MAReshuffle assumes that all ctors of mergeables belonging to the same merger in the same dex can be collapsed into a single new ctor. In practice, this is not the case as we also need to group ctors by protos.\n\nTo close the gap, we are going to proceed with the following changes:\n1) Directly use the info about dedupable vmethods and intf_methods in merging_model and not consider dmethods for deduping. The former would make the model more accurate, and the latter would make the model more conservative so that the last ~150 mrefs exceeding dex limit is taken care of.\n2) Make MAReshuffle a service that is called by IDCM, instead of its own pass. This way, the merging model configs shared by IDCM and MAReshuffle that are established in IDCM can easily be used by MAReshuffle, including but not limited to `exclude_types`.\n\nThis diff makes necessary changes for 1.\n\nReviewed By: beicy\n\nDifferential Revision: D56850663\n\nfbshipit-source-id: f47ac73614763985ecd453e3ba36abf61e6951ce","shortMessageHtmlLink":"More exact usage of merging model for method deduping"}},{"before":"b4a05c00b145c152a541faeb87087941fdb3c7eb","after":"53b7b18986972b73884d46768dc48702a5f23447","ref":"refs/heads/gh-pages","pushedAt":"2024-05-02T15:41:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 5ce3b2a07e560db368bb353cd13bc5c81c751068","shortMessageHtmlLink":"deploy: <a class=\"commit-link\" data-hovercard-type=\"commit\" data-hovercard-url=\"https://github.com/facebook/redex/commit/5ce3b2a07e560db368bb353cd13bc5c81c751068/hovercard\" href=\"https://github.com/facebook/redex/commit/5ce3b2a07e560db368bb353cd13bc5c81c751068\"><tt>5ce3b2a</tt></a>"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAESLM4ewA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/redex"}