Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TreeProp updates aren't given to children inside Sections #806

Open
1 task done
DSteve595 opened this issue Jul 14, 2021 · 1 comment
Open
1 task done

TreeProp updates aren't given to children inside Sections #806

DSteve595 opened this issue Jul 14, 2021 · 1 comment

Comments

@DSteve595
Copy link
Contributor

Version

0.40.0

Issues and Steps to Reproduce

Make a component that receives a TreeProp. Render that component inside a section. Update the component tree to have a newer TreeProp value. Observe that the component doesn't rerender with the new value for the TreeProp.

Expected Behavior

The component should rerender with the updated TreeProp.

Link to Code

Sample project

@astreet
Copy link
Contributor

astreet commented Jul 22, 2021

I'm unfortunately not surprised about this, however I don't think we are going to have time to work on fixing this in the near future. I'd suggest to either try to keep TreeProps for things which are static (e.g. a log tag, a toolbox, a logger, etc) for now unless you're feeling really motivated to dig in and send a PR :) I think we do need to fix this in the longer term and it's an important issue, we're just a bit constrained atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants