{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":4524181,"defaultBranch":"main","name":"folly","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2012-06-01T20:49:04.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714693538.0","currentOid":""},"activityList":{"items":[{"before":"9f125c94e10fd01f5567cdbc317f8026de3a20b5","after":"00b4d3230d8b9392e2c9929b9fee12daacaf2359","ref":"refs/heads/main","pushedAt":"2024-05-04T20:01:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"allow leaked instances of small_vector\n\nSummary:\nAllow code of this form:\n```\nstatic auto const& vec = std::invoke([] {\n  auto& vec = *new folly::small_vector</* ... */>();\n  // fill vec ...\n  return vec;\n});\n```\n\nPreviously, Leak Sanitizer (LSAN) would observe a leak since the internal data pointer within `small_vector` may be encoded.\n\nDifferential Revision: D56890898\n\nfbshipit-source-id: 3cc1110d41a055546f0fa3da1ac2c54de88e9c35","shortMessageHtmlLink":"allow leaked instances of small_vector"}},{"before":"9aa0c5cfae440da792a7a57365c4547520b52bdb","after":"9f125c94e10fd01f5567cdbc317f8026de3a20b5","ref":"refs/heads/main","pushedAt":"2024-05-03T20:54:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused-but-set variables in folly/test/ConcurrentSkipListBenchmark.cpp +5\n\nSummary:\nThis diff removes a variable that was set, but which was not used.\n\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused but set variables often indicate a programming mistake, but can also just be unnecessary cruft that harms readability and performance.\n\nThis set of diffs is divided into _simple_ and _complicated_ changes. This is a simple change, so I've verified by hand that it should be low-impact and safe to auto-land.\n\nFor the complex changes. Removing this variable will not change how your code works, but the unused variable may indicate your code isn't working the way you thought it was. I've gone through each of these by hand, but mistakes may have slipped through. If you feel the diff needs changes before landing, **please commandeer** and make appropriate changes: there are hundreds of these and responding to them individually is challenging.\n\nFor questions/comments, contact r-barnes.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: palmje, dmm-fb\n\nDifferential Revision: D56946781\n\nfbshipit-source-id: 096b38daec28eff928bc3aae051e91aea19dd5d2","shortMessageHtmlLink":"Remove unused-but-set variables in folly/test/ConcurrentSkipListBench…"}},{"before":"a68f401016aec8476fcd9793b570430c1cf86dda","after":"9aa0c5cfae440da792a7a57365c4547520b52bdb","ref":"refs/heads/main","pushedAt":"2024-05-03T20:48:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused-but-set variables in folly/test/BenchmarkIntegrationTest.cpp +1\n\nSummary:\nThis diff removes a variable that was set, but which was not used.\n\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused but set variables often indicate a programming mistake, but can also just be unnecessary cruft that harms readability and performance.\n\nRemoving this variable will not change how your code works, but the unused variable may indicate your code isn't working the way you thought it was. I've gone through each of these by hand, but mistakes may have slipped through. If you feel the diff needs changes before landing, **please commandeer** and make appropriate changes: there are hundreds of these and responding to them individually is challenging.\n\nFor questions/comments, contact r-barnes.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: dmm-fb\n\nDifferential Revision: D56887127\n\nfbshipit-source-id: 2bed0d354266750b988623b9caa8a1f9ae859be7","shortMessageHtmlLink":"Remove unused-but-set variables in folly/test/BenchmarkIntegrationTes…"}},{"before":"55a957c2e53ac9cbc6f90f2cd77c99c394fc80bb","after":"a68f401016aec8476fcd9793b570430c1cf86dda","ref":"refs/heads/main","pushedAt":"2024-05-03T20:42:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused-but-set variables in fboss/lib/config/PlatformConfigUtils.cpp +5\n\nSummary:\nThis diff removes a variable that was set, but which was not used.\n\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused but set variables often indicate a programming mistake, but can also just be unnecessary cruft that harms readability and performance.\n\nThis set of diffs is divided into _simple_ and _complicated_ changes. This is a simple change, so I've verified by hand that it should be low-impact and safe to auto-land.\n\nFor the complex changes. Removing this variable will not change how your code works, but the unused variable may indicate your code isn't working the way you thought it was. I've gone through each of these by hand, but mistakes may have slipped through. If you feel the diff needs changes before landing, **please commandeer** and make appropriate changes: there are hundreds of these and responding to them individually is challenging.\n\nFor questions/comments, contact r-barnes.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: palmje, dmm-fb\n\nDifferential Revision: D56946825\n\nfbshipit-source-id: 2bcd089cd19630822928ba43b3d04d4163958f5c","shortMessageHtmlLink":"Remove unused-but-set variables in fboss/lib/config/PlatformConfigUti…"}},{"before":"25d71d175f9b088b0cae9b45243ac30b0673418d","after":"55a957c2e53ac9cbc6f90f2cd77c99c394fc80bb","ref":"refs/heads/main","pushedAt":"2024-05-03T20:01:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"handle alternative platforms in folly lsan-marking\n\nSummary: Some alternative platforms may like to use a library which depends on these lsan-marking functions but which cannot use mutexes.\n\nDifferential Revision: D56936032\n\nfbshipit-source-id: 0eec06648e331d053b727b3f6b2afeb8fdfdb00e","shortMessageHtmlLink":"handle alternative platforms in folly lsan-marking"}},{"before":"862f69f835111943dac82264337cb9409c98add5","after":"25d71d175f9b088b0cae9b45243ac30b0673418d","ref":"refs/heads/main","pushedAt":"2024-05-03T19:32:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"rm experimental/TupleOps\n\nSummary: No one uses it\n\nReviewed By: luciang\n\nDifferential Revision: D55704584\n\nfbshipit-source-id: bb4040e808c817bbac8bd6ae898b2589642fff29","shortMessageHtmlLink":"rm experimental/TupleOps"}},{"before":"f0fdfc7d59c6cf7e1087338ff3995845e47d8d42","after":"862f69f835111943dac82264337cb9409c98add5","ref":"refs/heads/main","pushedAt":"2024-05-03T19:18:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"hide lsan interface wrappers under Windows\n\nSummary: The Windows runtime libraries do not include these lsan interface wrappers, so attempting to link to them won't work.\n\nDifferential Revision: D56917642\n\nfbshipit-source-id: aa58239a6a9d9e6af33da57beb96669c5aaeb60c","shortMessageHtmlLink":"hide lsan interface wrappers under Windows"}},{"before":"7a8ed70a5eae5b8d8102780dcac1a3b1538a3aa2","after":"f0fdfc7d59c6cf7e1087338ff3995845e47d8d42","ref":"refs/heads/main","pushedAt":"2024-05-03T18:29:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Ignore -Wclass-memaccess in small_vector's relocation\n\nSummary: This is deliberate, and also outside of the compiler's provable power.\n\nDifferential Revision: D56882778\n\nfbshipit-source-id: ade2e54df37a0007b730415955d0a384cf4858cf","shortMessageHtmlLink":"Ignore -Wclass-memaccess in small_vector's relocation"}},{"before":"61937a42ce879ef7b5f1b1bf6282ba69f0ebb560","after":"7a8ed70a5eae5b8d8102780dcac1a3b1538a3aa2","ref":"refs/heads/main","pushedAt":"2024-05-03T18:18:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"De-experimentalize channels/detail\n\nSummary:\nThe following targets were moved to folly/channels/detail:\n```\n//folly/experimental/channels/detail:atomic_queue\n//folly/experimental/channels/detail:channel_bridge\n//folly/experimental/channels/detail:function_traits\n//folly/experimental/channels/detail:intrusive_ptr\n//folly/experimental/channels/detail:multiplexer_traits\n//folly/experimental/channels/detail:pointer_variant\n//folly/experimental/channels/detail:utility\n//folly/experimental/channels/detail/test:atomic_queue_test\n//folly/experimental/channels/detail/test:pointer_variant_test\n```\n\n`arc f` was applied\n\nThis is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle.\nYou have been added as a reviewer by Sentinel or Butterfly.\n\nReviewed By: yfeldblum\n\nDifferential Revision: D56304154\n\nfbshipit-source-id: bb63b84686e6dfc75ba366d438da588f04d7daf4","shortMessageHtmlLink":"De-experimentalize channels/detail"}},{"before":"e30a6dce8a1283163c5e31b653223601e050a540","after":"61937a42ce879ef7b5f1b1bf6282ba69f0ebb560","ref":"refs/heads/main","pushedAt":"2024-05-03T17:08:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Move experimental/tool to json/tool\n\nSummary: It's a binary, not a library, so there's no outer-world dependencies. fbgs shows no results for `json_schema_tester`.\n\nReviewed By: yfeldblum\n\nDifferential Revision: D56316575\n\nfbshipit-source-id: c26dabcfd9edd7f7cd3c1d26f232c58d637e9375","shortMessageHtmlLink":"Move experimental/tool to json/tool"}},{"before":"fb093bbba142a301debf85fec852c5117c79666e","after":"e30a6dce8a1283163c5e31b653223601e050a540","ref":"refs/heads/main","pushedAt":"2024-05-03T16:36:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix windows build with --free-up-disk\n\nSummary:\ngetdeps can generate a windows wrapper script that can be used to run build artifacts from build directory.\n\nIn github actions for large projects we set a getdeps option delete the build dir as soon as we've successfully installed artefacts to save disk space. This option was enabled for windows in D56165825.   Turns out that didn't work, this diff adds the missing conditional so that it should.\n\nReviewed By: vitaut\n\nDifferential Revision: D56930778\n\nfbshipit-source-id: 0cb9ac94ef9b39f4e33af8fb91098dc0d833731b","shortMessageHtmlLink":"fix windows build with --free-up-disk"}},{"before":"4a726e5bd328aae5a5305ba5b0c3d20e671d1276","after":"fb093bbba142a301debf85fec852c5117c79666e","ref":"refs/heads/main","pushedAt":"2024-05-03T02:46:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Test that startInlineImpl() preserves the request context\n\nSummary: The `RequestContextScopeGuard` in `startInlineImpl()` has a non-obvious role, explain it in a comment and add a test that fails if the line is removed.\n\nReviewed By: iahs\n\nDifferential Revision: D56901147\n\nfbshipit-source-id: d12ff1272059f18170e357cc1cdb71560fd4a5e0","shortMessageHtmlLink":"Test that startInlineImpl() preserves the request context"}},{"before":"508edb50105b1b06d5272c39dd14f8702e801cb9","after":"4a726e5bd328aae5a5305ba5b0c3d20e671d1276","ref":"refs/heads/main","pushedAt":"2024-05-03T00:48:56.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"a helper function to count items marked as leaked\n\nSummary:\nA helper function `annotate_object_count_leaked_uncollected` to count items marked as leaked with `annotate_object_leaked` but not yet marked as collected with `annotate_object_collected`.\n\nCould be useful for various library facilities which might want to mark their internals as leaked and collected. This case arises when libraries hold owning pointers to allocated regions in encoded form.\n\nReviewed By: tophyr\n\nDifferential Revision: D56890896\n\nfbshipit-source-id: b56becbce39548afccec858efe82f56c368958aa","shortMessageHtmlLink":"a helper function to count items marked as leaked"}},{"before":"8df6a20f8c5f1d67c027be1eddd1ee69a35d41f1","after":"508edb50105b1b06d5272c39dd14f8702e801cb9","ref":"refs/heads/main","pushedAt":"2024-05-02T20:52:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"change python3 to fbpython\n\nSummary:\nthere is a bunch of scripts that uses python3 to run, this means that they are at the mercy of whoever controll their path, in linux, this can be system python3, but can also be platform python (and probably it is both), and in windows in particular it abuses c:\\tools\\fb-python\\python3.exe. fbpython is the universal way to run python at the company that chooses the right platform python, but also provides monitoring and observability.\n\nthis scripts generates jobs like\n\nhttps://www.internalfb.com/sandcastle/job/18014399781484898/\n\nthat will stop working once we remove c:\\tools\\fb-python\\python3*.exe\n\nReviewed By: fried\n\nDifferential Revision: D56896564\n\nfbshipit-source-id: d911fdaf6750635adb05b096f0522603baf47bcc","shortMessageHtmlLink":"change python3 to fbpython"}},{"before":"a9a82be8fa8e4312835de7e21cd87646495e418d","after":"8df6a20f8c5f1d67c027be1eddd1ee69a35d41f1","ref":"refs/heads/main","pushedAt":"2024-05-02T05:39:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove time.h include from folly-config.h\n\nSummary:\n`folly-config.h` included `time.h` in order to test for the `CLOCK_REALTIME` macro, which was a proxy to test for the `clock_gettime` function. This was for Apple platforms, which ages ago did not all export `clock_gettime`. But current and recent Apple platforms should all export it.\n\nAlso cut `glibc-rt` and `liburing` deps from `folly:config`.\n\nThe rule owning this header should depend on nothing.\n\n`autodeps` and `arc lint` breakage involving these deps originally reported by DenisYaroshevskiy in: https://fb.workplace.com/groups/560979627394613/posts/2913288488830370/.\n\n#buildall\n\nReviewed By: spikeh\n\nDifferential Revision: D56805126\n\nfbshipit-source-id: 7894de40c6de234ef05e8754ae6a733987a15477","shortMessageHtmlLink":"remove time.h include from folly-config.h"}},{"before":"502314157acb7fdff41d95487f3492064051feba","after":"a9a82be8fa8e4312835de7e21cd87646495e418d","ref":"refs/heads/main","pushedAt":"2024-05-02T01:17:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"in coro retry algorithm, allow max lower than min\n\nSummary: When max is lower than min, such as when max is 0, simply take min instead.\n\nReviewed By: darxsys\n\nDifferential Revision: D56846771\n\nfbshipit-source-id: cb6dc1e71547bca11b0d85fe57d0699a0cd0a7a0","shortMessageHtmlLink":"in coro retry algorithm, allow max lower than min"}},{"before":"b5f1bebf460276deaf7e5f21e12485d644e85715","after":"502314157acb7fdff41d95487f3492064051feba","ref":"refs/heads/main","pushedAt":"2024-05-02T00:18:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Back out \"Add check for minBackoff > maxBackoff in coro/Retry.h ExponentialBackoffWithJitter ctor\"\n\nSummary: Back out of D56646281. This caused too many failures in tests that do not initialize min and max correctly.\n\nReviewed By: yfeldblum\n\nDifferential Revision: D56847182\n\nfbshipit-source-id: 0f565cedafff9ef53d37c83df61e806b7584bfa0","shortMessageHtmlLink":"Back out \"Add check for minBackoff &gt; maxBackoff in coro/Retry.h Expon…"}},{"before":"89d633e8c893bc818335d181cdf8127703a05094","after":"b5f1bebf460276deaf7e5f21e12485d644e85715","ref":"refs/heads/main","pushedAt":"2024-05-01T23:54:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix for a compiler issue\n\nSummary:\nFix for a compiler issue\nUsing gcc, the folly/test:fbvector_test fails with a SIGSEGV\nIn folly/FBVector.h: S_uninitialized_fill_n, the following code leaves ```e``` unchanged (nullptr) after checked_add:\n\n```\n      T* e = nullptr;\n      if (!folly::checked_add(&e, dest, n)) {\n        throw_exception<std::length_error>(\"FBVector exceeded max size.\");\n      }\n```\n\nReviewed By: ahornby\n\nDifferential Revision: D56642541\n\nfbshipit-source-id: bf2258b17cf1ed32080932bc34d473a7d00cc969","shortMessageHtmlLink":"Fix for a compiler issue"}},{"before":"183187a2bc5add025c9b20b39261c61ac84747ad","after":"89d633e8c893bc818335d181cdf8127703a05094","ref":"refs/heads/main","pushedAt":"2024-05-01T23:47:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Propagate request context in StrandExecutor\n\nSummary: `StrandExecutor` should propagate the request context, consistently with all the other executors, otherwise tasks may run in the context of the task that scheduled the worker, which is incorrect.\n\nReviewed By: iahs\n\nDifferential Revision: D56828250\n\nfbshipit-source-id: 08d5b0fc5f7f9cb30b65472b1cc1b1a0fcee4935","shortMessageHtmlLink":"Propagate request context in StrandExecutor"}},{"before":"1f1028fee13c14f133b384afc5f014dbd00d4ab8","after":"183187a2bc5add025c9b20b39261c61ac84747ad","ref":"refs/heads/main","pushedAt":"2024-05-01T23:03:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"loosen type-info comparison under libc++\n\nSummary:\nWith libc++, we may get address-comparison for RTTI objects. If the linker does not fully merge all such symbols across all loaded .so's / dylibs, we get false mismatches. It is better in the case of UniqueInstance to err on the side of false matches than to err on the side of false mismatches.\n\nhttps://github.com/llvm/llvm-project/blob/llvmorg-18.1.4/libcxx/include/typeinfo#L117-L166\n\nReviewed By: bcardosolopes\n\nDifferential Revision: D56808919\n\nfbshipit-source-id: 453cac1f5f1e48c62394fa272b00d89f10675f54","shortMessageHtmlLink":"loosen type-info comparison under libc++"}},{"before":"16b65b36b553c3351217f81ea8cab84e1b76c1d8","after":"1f1028fee13c14f133b384afc5f014dbd00d4ab8","ref":"refs/heads/main","pushedAt":"2024-05-01T21:48:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Ensure that drained tasks in SerialExecutor run destructor under RequestContext\n\nSummary: In the (unlikely) case where the parent executor discards the worker task and we drain the queue, we should still honor the contract that the task's destructor is ran under in the request context of the submitter.\n\nReviewed By: iahs\n\nDifferential Revision: D56765678\n\nfbshipit-source-id: c70051ea73dc21dc321d61442251ee9dc32ee4d5","shortMessageHtmlLink":"Ensure that drained tasks in SerialExecutor run destructor under Requ…"}},{"before":"3259a180239edb7d8422baa9bf267f7d55aa11d2","after":"16b65b36b553c3351217f81ea8cab84e1b76c1d8","ref":"refs/heads/main","pushedAt":"2024-05-01T18:04:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Test allocations, not copies, in bulk heap_vector insert\n\nSummary:\nheap_vector's bulk-insert performs a sort, which performs some number of copies on the contained data. This is an implementation detail outside of the scope of heap_vector's testing. Instead of relying on this detail in tests, check what actually matters: that bulk insertion does not perform iterative insertion, and instead performs only one allocation.\n\nAccomplish this by using a custom allocator which tracks the number of allocate calls.\n\nDifferential Revision: D56823024\n\nfbshipit-source-id: 82fc7e488574400fd76b320eedd02ba6284637db","shortMessageHtmlLink":"Test allocations, not copies, in bulk heap_vector insert"}},{"before":"916938195455afbfa5d9f6fda8cdcf2f5fad741d","after":"3259a180239edb7d8422baa9bf267f7d55aa11d2","ref":"refs/heads/main","pushedAt":"2024-05-01T17:56:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix third-party/rust/Cargo.toml\n\nSummary:\nIt looks like D56546196 was incomplete. D56546196 added a new\ndependency, but didn't account for the case where the outside world\ntries to build buck2.\n\nThis diff fixes that.\n\nReviewed By: JakobDegen\n\nDifferential Revision: D56766826\n\nfbshipit-source-id: 3590056f3c5032bdc81d40855b1bf939a4686659","shortMessageHtmlLink":"Fix third-party/rust/Cargo.toml"}},{"before":"3ae49910af03aff55c8c12261c2bbe8143a7babc","after":"916938195455afbfa5d9f6fda8cdcf2f5fad741d","ref":"refs/heads/main","pushedAt":"2024-05-01T16:36:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary: GitHub commits:\n\nReviewed By: jurajh-fb\n\nfbshipit-source-id: 9e0e61af6e2138bb27d18f15dca179b697383738","shortMessageHtmlLink":"Updating submodules"}},{"before":"dcdbd4c8d5f6511086b219dacb3e7aeb7889c662","after":"3ae49910af03aff55c8c12261c2bbe8143a7babc","ref":"refs/heads/main","pushedAt":"2024-04-30T22:25:32.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add check for minBackoff > maxBackoff in coro/Retry.h ExponentialBackoffWithJitter ctor\n\nSummary:\nEnsure that ExponentialBackoffWithJitter is constructed with a minBackoff <= maxBackoff otherwise throw an exception.\n\nThere are some tests failing because minBackoff > maxBackoff (See T186982572).\n\nThrow at construction with a helpful message that contains the values of min and max, rather than waiting until later when ExponentialBackoffWithJitter is used.\n\nReviewed By: yfeldblum\n\nDifferential Revision: D56646281\n\nfbshipit-source-id: c2b3b7d3435a68b5df2c4d7d647357504fdaf82c","shortMessageHtmlLink":"Add check for minBackoff &gt; maxBackoff in coro/Retry.h ExponentialBack…"}},{"before":"ebeafaeb2c482d69958cf2d0e1e3959b139d219c","after":"dcdbd4c8d5f6511086b219dacb3e7aeb7889c662","ref":"refs/heads/main","pushedAt":"2024-04-29T19:16:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix flaky test failures in ThreadPoolExecutorTest.AddPerf\n\nSummary:\nThe test was intermittently failing because the inner `add` was executing after `stop` stopped the Executor. The fix is to hold a `KeepAlive` while the inner `add` is called, so the `stop` call blocks its shutdown process until all the `add` calls finish.\n\nIn more detail, the failure happened because of an assert failure of `DCHECK(DefaultKeepAliveExecutor->controlBlock_->keepAliveCount_ > 0)` in `DefaultKeepAliveExecutor::keepAliveAcquire`. The `stop` would decrement `DefaultKeepAliveExecutor->controlBlock_->keepAliveCount_` to `0` in `DefaultKeepAliveExecutor::keepAliveRelease`, before the `add` finished acquiring a keep alive token. Holding a keep alive in the tests ensures that `DefaultKeepAliveExecutor->controlBlock_->keepAliveCount_ > 0` while any `add` is takening place.\n\nReviewed By: yfeldblum\n\nDifferential Revision: D56654922\n\nfbshipit-source-id: 92f5317a32c7d15feb06b6182fda35e9f23964c5","shortMessageHtmlLink":"Fix flaky test failures in ThreadPoolExecutorTest.AddPerf"}},{"before":"2f1e04807617974c21c5ad7933130569e03e1ba9","after":"ebeafaeb2c482d69958cf2d0e1e3959b139d219c","ref":"refs/heads/main","pushedAt":"2024-04-29T17:55:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"airstore next: bundle V4: thrift working in OSS build\n\nSummary: this diff adds support for thrift in the OSS client build. it changes the `getdeps` airstore manifest to gain access to the thrift cpp2 compiler, then uses a rule similar to other projects to generate the cpp type headers. It changes the OSS `libbundle` library to depend on the thrift types introduced in D56578073 (and, through a lot of pain, get generated in the OSS build stack) which will then be used to ser/de bundles in the OSS build later in the stack!\n\nReviewed By: ASchneidman\n\nDifferential Revision: D56578071\n\nfbshipit-source-id: 1a8d906d0f7a24da21fe7f225fe68644c6bc49d7","shortMessageHtmlLink":"airstore next: bundle V4: thrift working in OSS build"}},{"before":"42ce936ff0abdf994bad7ceec8d7acb63b3d00d8","after":"2f1e04807617974c21c5ad7933130569e03e1ba9","ref":"refs/heads/main","pushedAt":"2024-04-28T17:12:07.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add libiberty manifest for folly to use\n\nSummary: Add a manifest for libiberty so that folly open source builds pick it up and use the demangler when showing stack traces\n\nReviewed By: dmm-fb\n\nDifferential Revision: D56679872\n\nfbshipit-source-id: 622090112e19a5dd0d2b58a36dead0ea81e89026","shortMessageHtmlLink":"add libiberty manifest for folly to use"}},{"before":"94182f8495c7b153a2341b2503d6536149da108b","after":"42ce936ff0abdf994bad7ceec8d7acb63b3d00d8","ref":"refs/heads/main","pushedAt":"2024-04-28T16:44:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Inherit iterator_category from base iterator.\n\nSummary:\nSingletonThreadLocal and StaticContextAccessor both derive their\nIterators from the accessAllThreads() implementation. They should inherit the\ncategory tag too instead of assuming it is bidirectional.\n\nReviewed By: yfeldblum, ppanchalia\n\nDifferential Revision: D56675899\n\nfbshipit-source-id: 1304c7c8ca691e5de1da5e001312b32c3404fbc8","shortMessageHtmlLink":"Inherit iterator_category from base iterator."}},{"before":"58e8d1a88d6c75547cd7221027ca3d4c78eb08ca","after":"94182f8495c7b153a2341b2503d6536149da108b","ref":"refs/heads/main","pushedAt":"2024-04-28T07:49:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Refactor iterator walk for accessAllThreads\n\nSummary:\nChange the ThreadEntrySet as suggested in D55115468 comments to be a\nvector plus a map of pointers into the vector.\n\nReviewed By: yfeldblum\n\nDifferential Revision: D56665857\n\nfbshipit-source-id: 81ba1161b3c388aec05598fa26fecdd7d84b7b33","shortMessageHtmlLink":"Refactor iterator walk for accessAllThreads"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQY_CpAA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/folly"}