Handle type validation for string type hints #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Pull Request Test Coverage Report for Build 4629934671
💛 - Coveralls |
|
@deathowl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
LGTM 👍 |
williamlw999-fb
force-pushed
the
handle_str_types
branch
7 times, most recently
from
a6c77a2
to
1f598d2
Compare
|
So this pull just needs to run isort? Snippet from the failed Checks |
|
just run make format |
Summary:
With `from __future__ import annotations`, all type hints become strings. The current type validator assumes that what is being checked is a type and not a string, so no types are being validated in these cases.
The fix is to use Python's typing.get_type_hints to evaluate the type hints at runtime
- [x] Added tests, if you've added code that should be tested
- [x] Ensured the test suite passes
- [x] Made sure your code lints
- [x] Completed the Contributor License Agreement ("CLA")
Pull Request resolved: facebook#333
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
New unit tests were added to check that function parameters and return types were being interpreted correctly when annotated as a string (which is the case with from __future__ import annotations)
Reviewed By: deathowl
Differential Revision: D35778959
Pulled By: williamlw999-fb
fbshipit-source-id: 20ad9fbbb22c8189a9ba650729b99f5c59a24a16
|
This pull request was exported from Phabricator. Differential Revision: D35778959 |
williamlw999-fb
force-pushed
the
handle_str_types
branch
from
1f598d2
to
f9cadc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
from __future__ import annotations, all type hints become strings. The current type validator assumes that what is being checked is a type and not a string, so no types are being validated in these cases.The fix is to use Python's typing.get_type_hints to evaluate the type hints at runtime