Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending Models.THOMPSON with an extra parameter #2334

Open
seabull opened this issue Apr 8, 2024 · 1 comment
Open

Extending Models.THOMPSON with an extra parameter #2334

seabull opened this issue Apr 8, 2024 · 1 comment
Assignees

Comments

@seabull
Copy link

seabull commented Apr 8, 2024

Hello Ax team,

We are looking to extend the Thompson model with an annealing parameter. The call would be like the following:

# The current Ax Thompson 
# Models.THOMPSON(
#                experiment=my_experiment,
#                data=trial_data,
#                min_weight=min_weight,
#            )

# EXTENDED_THOMPSON would extend from current Ax Thompson
Models.EXTENDED_THOMPSON(
                experiment=my_experiment,
                data=trial_data,
                min_weight=min_weight,
                anneal_factor=anneal_factor,
            )

The current Ax library doesn't support extending the model with an extra parameter. To make it work, we had to fork Ax library and add EXTENDED_THOMPSON to the source code, which is not ideal.

I wonder whether the Ax library could be enhanced to support extra parameters in the Thompson model (and/or other models) or other alternatives to make models extend-able?

@sdaulton
Copy link
Contributor

sdaulton commented Apr 8, 2024

Hi @seabull,

Feel free to open a pull request that adds this new parameter to Models.THOMPSON! Contributions are always welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants