Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly broken tags styling #377

Open
Seven0fNine opened this issue May 25, 2023 · 3 comments
Open

Possibly broken tags styling #377

Seven0fNine opened this issue May 25, 2023 · 3 comments

Comments

@Seven0fNine
Copy link

Seven0fNine commented May 25, 2023

Hi!
Since yesterday I'm using Todo+ (v4.19.1) and it's amazing. Thank you so much.
At the moment I have an issue with special tags.
Although I added them and adjusted the styling in settings.json, this special tags aren't styled correctly.
cms, fron and pega should have red background. Instead pega has yellow font and all other special tags are unstyled.
Is this a bug or did I missed sth? :)
Thank you!
Annika
image
image

@fabiospampinato
Copy link
Owner

It looks like a bug 🤔 Do the built-in settings work for you or is for example @critical not styled specially there either? I don't remember if this other extension works in combination with Todo+, but worth a short to see if this can be supported with that for the time being.

@fabiospampinato fabiospampinato changed the title Special Tags - Styling Possibly broken tags styling Aug 2, 2023
@Sheepolution
Copy link

Sheepolution commented Sep 9, 2023

It seems to be the case that anything you add to the default doesn't work. If you add a tag (eg. @progress) and a color, you won't get any highlighting. But if you were to switch around @progress with @critical, then @progress will appear red, and @critical won't have any highlighting.

@Sheepolution
Copy link

Sheepolution commented Sep 9, 2023

No time and knowledge on how to debug this, but here are my finding:

  1. When adding a special tag with a special color, that new color will only be used after a restart.
  2. When adding no special color, the newly added tag won't have the default highlighting. Instead, ALL tags EXCEPT the added tag will have the highlighting.
  3. But if you add yet another special tag with no color, this seems to be fixed.
  4. After a restart however, the problem returns to the tags no longer working, and all other tags getting highlighting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants