Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Words after two consecutive double quotes (--) disapper on the embedded view #363

Open
solzard opened this issue Nov 18, 2022 · 3 comments

Comments

@solzard
Copy link

solzard commented Nov 18, 2022

This extension's embedded view erases words after two consecutive double quotes (--) of every comment.

These two comment lines on a python file ↓
comment

Appear as the below on the embedded view ↓

embedded view

Which config do I need to change to stop the view truncating words after --?


Environment:
VSCode:

  • Version: 1.73.1
  • Commit: 6261075646f055b99068d3688932416f2346dd3b
  • Date: 2022-11-09T02:22:48.959Z
  • Electron: 19.0.17
  • Chromium: 102.0.5005.167
  • Node.js: 16.14.2
  • V8: 10.2.154.15-electron.0
  • OS: Darwin arm64 21.6.0
  • Sandboxed: No

Extension: v4.18.4

@fabiospampinato
Copy link
Owner

I think perhaps because the extension thinks that's the start of a comment.

The setting to change should be this one:

  "todo.embedded.regex": "(?:<!-- *)?(?:#|// @|//|/\\*+|<!--|--|\\* @|\\{!|\\{\\{!--|\\{\\{!) *(TODO|FIXME|FIX|BUG|UGLY|HACK|NOTE|IDEA|REVIEW|DEBUG|OPTIMIZE)(?:\\s*\\([^)]+\\))?:?(?!\\w)(?: *-->| *\\*/| *!}| *--}}| *}}|(?= *(?:[^:]//|/\\*+|<!--|@|--|\\{!|\\{\\{!--|\\{\\{!))|((?: +[^\\n@]*?)(?= *(?:[^:]//|/\\*+|<!--|@|--(?!>)|\\{!|\\{\\{!--|\\{\\{!))|(?: +[^@\\n]+)?))", // Regex used for finding embedded todos, requires double escaping

Maybe you can just replace |--| with | 🤔

@solzard
Copy link
Author

solzard commented Nov 18, 2022

I replaced both of |--| with | and reload the VSCode, but unfortunately, it didn't work.

"todo.embedded.regex": "(?:<!-- *)?(?:#|// @|//|/\\*+|<!--|\\* @|\\{!|\\{\\{!--|\\{\\{!) *(TODO|FIXME|FIX|BUG|UGLY|HACK|NOTE|IDEA|REVIEW|DEBUG|OPTIMIZE)(?:\\s*\\([^)]+\\))?:?(?!\\w)(?: *-->| *\\*/| *!}| *--}}| *}}|(?= *(?:[^:]//|/\\*+|<!--|@|\\{!|\\{\\{!--|\\{\\{!))|((?: +[^\\n@]*?)(?= *(?:[^:]//|/\\*+|<!--|@|--(?!>)|\\{!|\\{\\{!--|\\{\\{!))|(?: +[^@\\n]+)?))"

@fabiospampinato
Copy link
Owner

Maybe it was another regex, can you try with: "todo.embedded.providers.ag.regex" and "todo.embedded.providers.rg.regex"? Same edit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants