Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabio is using Datadog reserved tag keys #923

Open
froque opened this issue Feb 7, 2023 · 1 comment · May be fixed by #924
Open

Fabio is using Datadog reserved tag keys #923

froque opened this issue Feb 7, 2023 · 1 comment · May be fixed by #924

Comments

@froque
Copy link

froque commented Feb 7, 2023

Some metrics are sent with tags service, host, path, target:

fabio/route/route.go

Lines 64 to 66 in 642e425

Timer: counters.histogram.With("service", service, "host", r.Host, "path", r.Path, "target", targetURL.String()),
RxCounter: counters.rxCounter.With("service", service, "host", r.Host, "path", r.Path, "target", targetURL.String()),
TxCounter: counters.txCounter.With("service", service, "host", r.Host, "path", r.Path, "target", targetURL.String()),

But service and host are reserved tag keys in Datadog

According to Host tag

The host tag is assigned automatically by the Datadog Agent aggregating the metrics. Metrics submitted with a host tag not matching the Agent hostname lose reference to the original host. The submitted host tag overrides any hostname collected by or configured in the Agent.

and DataDog/datadog-agent#6245, these metric loose any configuration in the datadog-agent. In our case it is the env tag that is being lost.

It can be tested with:

echo -n "custom.metric.nameA:1|c|#host:foo" |nc -vu -w1 localhost 8125

image

echo -n "custom.metric.nameB:1|c|#host1:foo" |nc -vu -w1 localhost 8125

Screenshot 2023-02-07 at 11-35-13 Metrics Summary Datadog2
@froque froque linked a pull request Feb 7, 2023 that will close this issue
Open
@ngcmac
Copy link

ngcmac commented Apr 18, 2023

Any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds handling of Datadog reserved tag keys froque/fabio
2 participants
@froque @ngcmac