Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for setting tags on newly created task definitions #206

Open
nwsparks opened this issue May 2, 2022 · 2 comments · May be fixed by #211
Open

add support for setting tags on newly created task definitions #206

nwsparks opened this issue May 2, 2022 · 2 comments · May be fixed by #211

Comments

@nwsparks
Copy link

nwsparks commented May 2, 2022

It would be helpful to be able to define tags when deploying using ecs-deploy.

We use this tool to coordinate deployments, but Terraform to create the initial task definition. It would be great if we could set tags then to differentiate between the definitions created by this tool, and the ones created by Terraform.

Out specific use case is that we would like to cleanup old task definitions created by ecs-deploy, but not the ones created by Terraform.
@myufa
Copy link

myufa commented Feb 23, 2023

Bumping this, it would be very helpful!

@nwsparks
Copy link
Author

nwsparks commented Feb 28, 2023 •
edited

an alternative to this could be an option to not copy the tags so that ecs deploy resources were created without tags in order to distinguish them.

the code that is doing the copying of tags was added here #139

mheiges pushed a commit to mheiges/ecs-deploy that referenced this issue Mar 7, 2023
add support for managing tags on task definitions
7320999 
closes fabfuel#206
@mheiges mheiges linked a pull request Mar 15, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add support for managing tags on task definitions mheiges/ecs-deploy
2 participants
@nwsparks @myufa