Skip to content
This repository has been archived by the owner on Aug 9, 2020. It is now read-only.

Add switch to choose between OVPN and conf file extensions #11

Open
ezaquarii opened this issue Jun 20, 2018 · 6 comments
Open

Add switch to choose between OVPN and conf file extensions #11

ezaquarii opened this issue Jun 20, 2018 · 6 comments
Labels
enhancement New feature or request first-timers-only good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ezaquarii
Copy link
Owner

ezaquarii commented Jun 20, 2018

When you download (or send) the config file, it has extension conf. This works well for Linux, but Mac and Windows users expect profile files to have extension ovpn. I believe this should be a configurable option.

There is couple of things to do.

URL creation:
vpnathome.apps.openvpn.serializers.ClientSerializer
vpnathome.apps.openvpn.serializers.ServerSerializer

Filename is model attribute:
vpnathome.apps.openvpn.models.Client.filename
vpnathome.apps.openvpn.models.Server.filename

Filename generation should be probably moved to serializer and extension injected via context.

Frontend requires another settings page and file extension setting should be added to:
vpnathome.apps.management.models.Settings.

Unit tests are a must.

@ezaquarii ezaquarii added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jun 20, 2018
@neil007m
Copy link

neil007m commented Jan 2, 2019

@ezaquarii Hi! I was wondering if you could provide some more input about this issue? First timer here, so I'll probably have a lot of redundant questions, apologies in advance for that.

@ezaquarii
Copy link
Owner Author

@ezaquarii Hi! I was wondering if you could provide some more input about this issue? First timer here, so I'll probably have a lot of redundant questions, apologies in advance for that.

Pls see updated ticket description. This will require some work with Python & Django, JavaScript & Vue.js.

@nhughey
Copy link

nhughey commented Jun 12, 2019

Is anyone working on this still? I'd like to submit a pull request and help out if not.

@ezaquarii
Copy link
Owner Author

ezaquarii commented Jun 12, 2019 via email

@ritesh-pandey
Copy link

I want to take this up as no one else has submitted a PR till now. Also, I've added a draft PR. Please let me know if this is the way you want to fix it.

@barshopen
Copy link

Hi, is this feature still free for the taking? Is it still needed? No one took it already?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request first-timers-only good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants