Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWXMLHash 6.0.0 Compatibility #769

Open
jminutaglio opened this issue Sep 29, 2021 · 4 comments
Open

SWXMLHash 6.0.0 Compatibility #769

jminutaglio opened this issue Sep 29, 2021 · 4 comments

Comments

@jminutaglio
Copy link

SWXMLHash 6.0.0 renames the main class from SWXMLHash to XMLHash.

This impacts Macaw in SVGParser -> parse()

changing to (lines 135-150) resolves:

    fileprivate func parse() throws -> Group {
        let config = XMLHash.config { config in
            config.shouldProcessNamespaces = true
        }
        let parsedXml = config.parse(xmlString)

        var svgElement: XMLHash.XMLElement?
        for child in parsedXml.children {
            if let element = child.element {
                if element.name == "svg" {
                    svgElement = element
                    try prepareSvg(child.children)
                    break
                }
            }
        }
@NeedNap
Copy link

NeedNap commented Sep 30, 2021

The same happens to me

@silvansky
Copy link

SWXMLHash version should be locked in podspec file until 6.0.0 is supported.

@razon30
Copy link

razon30 commented Oct 2, 2021

Facing the same issue.

mnndnl added a commit that referenced this issue Oct 4, 2021
@MaxenceMax
Copy link

Same issue here

ystrot added a commit that referenced this issue Oct 8, 2021
yuzhiyou1990 added a commit to yuzhiyou1990/Macaw that referenced this issue Sep 20, 2022
commit 9c087ea
Author: Yuri Strot <ystrot@gmail.com>
Date:   Sun May 15 18:42:57 2022 +0700

    Update README.md

commit a3ddf65
Author: Yuri Strot <ystrot@gmail.com>
Date:   Sun May 15 18:32:07 2022 +0700

    Add deprecation image

commit 29ec199
Merge: d508348 9797fb0
Author: Yuri Strot <ystrot@gmail.com>
Date:   Thu Apr 21 16:59:18 2022 +0700

    Merge pull request exyte#781 from hotbott/master

    Native Image Scale

commit 9797fb0
Author: Sebastian Bott <BottSebastian@JohnDeere.com>
Date:   Thu Dec 2 17:42:55 2021 +0100

    Bump version

commit 96e4900
Author: Sebastian Bott <BottSebastian@JohnDeere.com>
Date:   Thu Dec 2 17:42:32 2021 +0100

    Fix native image scale

commit 197903c
Author: Sebastian Bott <BottSebastian@JohnDeere.com>
Date:   Thu Dec 2 17:42:08 2021 +0100

    Add render dispose

commit d508348
Author: Alisa Mylnikova <f3dm76@gmail.com>
Date:   Fri Oct 29 15:04:40 2021 +0700

    Bump version

commit 5cde520
Merge: f9c0972 7b54dda
Author: Yuri Strot <ystrot@gmail.com>
Date:   Fri Oct 29 15:01:43 2021 +0700

    Merge pull request exyte#779 from exyte/fix/smooth-group-animation

    fix unsmooth group animation

commit 7b54dda
Author: Mark Goldin <marky_gold@me.com>
Date:   Fri Oct 29 14:57:38 2021 +0700

    fix unsmooth group animation

commit f9c0972
Author: Alisa Mylnikova <f3dm76@gmail.com>
Date:   Fri Oct 8 17:23:41 2021 +0700

    Bump version

commit 931cbdb
Merge: b332010 26271bc
Author: Yuri Strot <ystrot@gmail.com>
Date:   Fri Oct 8 16:45:34 2021 +0700

    Merge pull request exyte#773 from exyte/fix-tests-unwrapping

    Fix image unwrapping, some crashes

commit 26271bc
Merge: 6415858 b332010
Author: Yuri Strot <ystrot@gmail.com>
Date:   Fri Oct 8 16:45:19 2021 +0700

    Merge branch 'master' into fix-tests-unwrapping

commit b332010
Merge: 2b406e5 dfcfdbe
Author: Yuri Strot <ystrot@gmail.com>
Date:   Fri Oct 8 16:43:17 2021 +0700

    Merge pull request exyte#772 from exyte/769-SWXMLHash-Compatibility

    exyte#769 SWXMLHash Compatibility

commit 6415858
Author: Daniil Manin <manindaniil@gmail.com>
Date:   Tue Oct 5 14:09:55 2021 +0700

    Update renderToImage method, optional image

commit d5ae291
Author: Daniil Manin <manindaniil@gmail.com>
Date:   Tue Oct 5 14:06:48 2021 +0700

    Fix test's method - to native image, add throw CommonError.invalidImageContext

commit dfcfdbe
Author: Daniil Manin <manindaniil@gmail.com>
Date:   Mon Oct 4 17:58:51 2021 +0700

    Update indents

commit cc7513b
Author: Daniil Manin <manindaniil@gmail.com>
Date:   Mon Oct 4 17:50:17 2021 +0700

    exyte#769 Update SWXMLHash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants