Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong diff highlighting for "no newline at end of file" #2223

Open
knuesel opened this issue May 9, 2024 · 0 comments
Open

Wrong diff highlighting for "no newline at end of file" #2223

knuesel opened this issue May 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@knuesel
Copy link

knuesel commented May 9, 2024

When a file without newline at the end is "fixed" by adding a newline, the diff view shows the message "\ No newline at end of file" in green:

image

This is a bit misleading, it suggests that the change was to remove the newline rather than add it.

For comparison here's how it looks with the default git diff:

image

(tested on gitui 0.26.1)

@knuesel knuesel added the bug Something isn't working label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant