Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot commit with empty e-mail. #2178

Open
Densaugeo opened this issue Apr 12, 2024 · 2 comments
Open

Cannot commit with empty e-mail. #2178

Densaugeo opened this issue Apr 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Densaugeo
Copy link

Describe the bug
When git is configured with an empty e-mail address, gitui does not allow commits.

To Reproduce
Steps to reproduce the behavior:

git config --global user.email "<>"
git init foo
cd foo
echo "some content" > a_file.txt
gitui
# Stage a_file.txt
# Hit "c" to start a commit
# Type any commit message and hit enter

Expected behavior
A new commit should be created.

Screenshots
image

Context (please complete the following information):

  • Fedora 39
  • GitUI 0.24.3
  • Git 2.44.0
@Densaugeo Densaugeo added the bug Something isn't working label Apr 12, 2024
@extrawurst
Copy link
Owner

That is literally not an empty string 😂

pretty sure that’s an upstream issue in libgit2

@Densaugeo
Copy link
Author

For some reason, I though git didn't allow actual empty strings and used <> to represent them. Not sure where I got the idea.

Anyway, I did a quick test with email = in my .gitconfig file, and I got a similar error message:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants