Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Resources/organization #487

Open
bhelx opened this issue Sep 25, 2023 · 5 comments
Open

Testing: Resources/organization #487

bhelx opened this issue Sep 25, 2023 · 5 comments
Assignees

Comments

@bhelx
Copy link
Contributor

bhelx commented Sep 25, 2023

  • Where do we store the test .wasm files how do we keep them versioned? Probably makes sense to keep them in one repo then use git submodules but we also discussed maybe building some infrastructure around this
  • Ensure that the extism-runtime.wasm kernel is updated automatically, or semi-automatically (4 hours)
    • SDKs that require the kernel should get automatic PRs when this file changes
@bhelx
Copy link
Contributor Author

bhelx commented Sep 25, 2023

I part 1 was taken care of with the extism/plugins repo

@zshipko is part 2 take care of by the development build process?

@zshipko
Copy link
Contributor

zshipko commented Sep 25, 2023

The only thing left is to update the go-sdk and js-sdk when the kernel changes. I think this could be considered complete and we can open some issues on those repos for more specific tasks.

@neuronicnobody
Copy link
Contributor

Can continue manual approach for now while determining how to automate more fully

@chrisdickinson
Copy link
Contributor

Noting that I'll take this on as a back-burner task. Goals are:

  • Make sure the Go and JS SDKs continue to work against extism-runtime.wasm changes
  • Keep the extism-runtime.wasm file vendored in the Go and JS SDKs up-to-date automatically. (Possibly by submitting PRs against those repos whenever the runtime artifact changes.)

@nilslice
Copy link
Member

nilslice commented Oct 3, 2023

@chrisdickinson this may be a viable option... https://github.com/orgs/community/discussions/49745

Imagine running a step like this (opening a PR with the new kernel to go-sdk and js-sdk) from the release action in extism/extism

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants