Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethereum derivation path is used instead of Expanse, when launch Mist wallet with connected Trezor #44

Open
DimmOFF opened this issue Jul 27, 2020 · 1 comment

Comments

@DimmOFF
Copy link

DimmOFF commented Jul 27, 2020

When I launch Mist Wallet with connected Trezor wallet, it loads the first address from Trezor, but with Ethereum derivation path m/44'/60'/0'/0.
It must be m/44'/40'/0'/0 for Expanse.
If I'm right, here is where the fix must be done https://github.com/expanse-org/go-expanse/blob/v1.9.x/accounts/hd.go

System information

Gexp version: v1.9.10-stable
OS & Version: Windows 10
Commit hash : d57c0cd

Expected behaviour

The first Expanse address from derivation path m/44'/40'/0'/0 is loaded

Actual behaviour

The first Ethereum address from derivation path m/44'/60'/0'/0 is loaded

Steps to reproduce the behavior

  1. Connect and unlock Trezor Model T wallet.
  2. Launch Mist Wallet.
  3. See the log file %AppData%\Expanse Wallet\node.log

node.log

@DimmOFF DimmOFF changed the title Ethereum derivation path is uses instead of Expanse, when launch Mist wallet with connected Trezor Ethereum derivation path is used instead of Expanse, when launch Mist wallet with connected Trezor Jul 27, 2020
chrisfranko pushed a commit that referenced this issue May 26, 2021
…thereum#22668)

* eth/protocols/snap: generate storage trie from full dirty snap data

* eth/protocols/snap: get rid of some more dead code

* eth/protocols/snap: less frequent logs, also log during trie generation

* eth/protocols/snap: implement dirty account range stack-hashing

* eth/protocols/snap: don't loop on account trie generation

* eth/protocols/snap: fix account format in trie

* core, eth, ethdb: glue snap packets together, but not chunks

* eth/protocols/snap: print completion log for snap phase

* eth/protocols/snap: extended tests

* eth/protocols/snap: make testcase pass

* eth/protocols/snap: fix account stacktrie commit without defer

* ethdb: fix key counts on reset

* eth/protocols: fix typos

* eth/protocols/snap: make better use of delivered data (#44)

* eth/protocols/snap: make better use of delivered data

* squashme

* eth/protocols/snap: reduce chunking

* squashme

* eth/protocols/snap: reduce chunking further

* eth/protocols/snap: break out hash range calculations

* eth/protocols/snap: use sort.Search instead of looping

* eth/protocols/snap: prevent crash on storage response with no keys

* eth/protocols/snap: nitpicks all around

* eth/protocols/snap: clear heal need on 1-chunk storage completion

* eth/protocols/snap: fix range chunker, add tests

Co-authored-by: Péter Szilágyi <peterke@gmail.com>

* trie: fix test API error

* eth/protocols/snap: fix some further liter issues

* eth/protocols/snap: fix accidental batch reuse

Co-authored-by: Martin Holst Swende <martin@swende.se>
@chrisfranko
Copy link
Member

If we fix this for Trezor itll break for everything else. Sadly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants