Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daap windows compatibility #756

Open
ecleeEEL opened this issue May 3, 2021 · 1 comment
Open

daap windows compatibility #756

ecleeEEL opened this issue May 3, 2021 · 1 comment

Comments

@ecleeEEL
Copy link

ecleeEEL commented May 3, 2021

Steps to Reproduce (for bugs)

  1. Had difficulties enabling Daap for windows, all enclosed in dependencies
  2. First issue was python-zeroconf. this package was crashing when attempting to set up ports on link-local. i hacked in try cases to ignore the error and continue to the next interface that worked
  3. Second issue was with spydaap. the version i pulled from pip didn't handle bytearrays/strings correctly (python3)

Expected Behavior

Current Behavior

spydaap was unable to parse the daap dictionary because the byte string didn't match the strings in daaptypes. this prevented connecting to the discovered shares

Possible Solution

i can provide a hack patch that works, but didn't know if i'm building it correctly with the right dependencies (spydaap) sourced in. i have a feeling this has already been addressed if i had the right build environment

Environment

  • Operating System and version: msys2
  • Exaile Version: head
@rokm
Copy link
Member

rokm commented May 3, 2021

Second issue was with spydaap. the version i pulled from pip didn't handle bytearrays/strings correctly (python3)

For spydaap, we have our fork at https://github.com/exaile/spydaap, and that one has a py3 branch which aims for python3 compatibility (we should probably switch/merge it to master now). I've tested it only on linux and in client mode, though (i.e., using the DAAP client plugin).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants