Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check correctness of OperatorBase::is_mg #641

Open
nfehn opened this issue Jan 23, 2024 · 2 comments
Open

Check correctness of OperatorBase::is_mg #641

nfehn opened this issue Jan 23, 2024 · 2 comments

Comments

@nfehn
Copy link
Member

nfehn commented Jan 23, 2024

Related to issue #639, it is not clear whether the member variable is_mg is handled correctly in OperatorBase, see

// The default value is is_mg = false and this variable is set to true in case
// the operator is applied in multigrid algorithm. By convention, the default
// argument dealii::numbers::invalid_unsigned_int corresponds to the default
// value is_mg = false
this->is_mg = (this->level != dealii::numbers::invalid_unsigned_int);

@peterrum @kronbichler Could one of you also check the remaining occurrences of is_mg in OperatorBase? If the implementation is correct, we should nevertheless think about a better name, because it seems that is_mg does not necessarily describe whether an object of type OperatorBase is used as a PDE level operator in multigrid or not.

@nfehn
Copy link
Member Author

nfehn commented Jan 23, 2024

suggestion for renaming: is_mg -> matrix_free_operates_on_coarser_tria_level

@peterrum
Copy link
Member

suggestion for renaming: is_mg -> matrix_free_operates_on_coarser_tria_level

Sounds reasonable.

There are other places where the term is_mg is used. I think similar to #640, we could rename these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants