Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does Elementwise::SolverCG call vector_init(solution) on initial solution #577

Open
nfehn opened this issue Aug 17, 2023 · 0 comments
Open

Comments

@nfehn
Copy link
Member

nfehn commented Aug 17, 2023

The solution vector passed to the solve function gets initialized with zero in the elementwise CG solver. It is unclear to me why this is done. See

When initializing with zero, the subsequent matrix-vector product seems to be superfluous.

I tend to say that the solver should work with the solution vector as passed to the solve function.

@kronbichler what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant