We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The solution vector passed to the solve function gets initialized with zero in the elementwise CG solver. It is unclear to me why this is done. See
solution
exadg/include/exadg/solvers_and_preconditioners/solvers/elementwise_krylov_solvers.h
Line 278 in e8462c4
When initializing with zero, the subsequent matrix-vector product seems to be superfluous.
I tend to say that the solver should work with the solution vector as passed to the solve function.
@kronbichler what do you think?
The text was updated successfully, but these errors were encountered:
No branches or pull requests
The
solution
vector passed to the solve function gets initialized with zero in the elementwise CG solver. It is unclear to me why this is done. Seeexadg/include/exadg/solvers_and_preconditioners/solvers/elementwise_krylov_solvers.h
Line 278 in e8462c4
When initializing with zero, the subsequent matrix-vector product seems to be superfluous.
I tend to say that the solver should work with the
solution
vector as passed to the solve function.@kronbichler what do you think?
The text was updated successfully, but these errors were encountered: