Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config labels don't work #1

Open
radojko opened this issue Dec 27, 2019 · 3 comments
Open

Config labels don't work #1

radojko opened this issue Dec 27, 2019 · 3 comments

Comments

@radojko
Copy link

radojko commented Dec 27, 2019

Levels iteration in for loop in configureLevelsLabels() is wrong, it should be this.levels.length in line 141:
https://github.com/ewwink/clappr-quality-selector-plugin/blob/74e074deffb8e7480d6856ab764bb6453f1b7742/quality-selector.js#L141

BTW. original code in clappr-level-selector-plugin was good :)
for (let levelId in this.levels) {
level = this.levels[levelId]

@ewwink
Copy link
Owner

ewwink commented Dec 27, 2019

I miss that because I never use labels, will fix it soon, thanks.

original code use ES6 and it use npm and some Clappr dependency cannot be installed on my Windows that why I convert the code to ES5.

@a6doff
Copy link

a6doff commented Sep 10, 2020

Any news about that?

@radojko
Copy link
Author

radojko commented Sep 15, 2020

Any news about that?

As I remember you only have to change in line 141 "this.levels" to "this.levels.length".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants