We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Levels iteration in for loop in configureLevelsLabels() is wrong, it should be this.levels.length in line 141: https://github.com/ewwink/clappr-quality-selector-plugin/blob/74e074deffb8e7480d6856ab764bb6453f1b7742/quality-selector.js#L141
BTW. original code in clappr-level-selector-plugin was good :) for (let levelId in this.levels) { level = this.levels[levelId]
The text was updated successfully, but these errors were encountered:
I miss that because I never use labels, will fix it soon, thanks.
original code use ES6 and it use npm and some Clappr dependency cannot be installed on my Windows that why I convert the code to ES5.
Sorry, something went wrong.
Any news about that?
As I remember you only have to change in line 141 "this.levels" to "this.levels.length".
No branches or pull requests
Levels iteration in for loop in configureLevelsLabels() is wrong, it should be this.levels.length in line 141:
https://github.com/ewwink/clappr-quality-selector-plugin/blob/74e074deffb8e7480d6856ab764bb6453f1b7742/quality-selector.js#L141
BTW. original code in clappr-level-selector-plugin was good :)
for (let levelId in this.levels) {
level = this.levels[levelId]
The text was updated successfully, but these errors were encountered: