Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stroke is either wholly blocked or not blocked, and only one type of input is processed per stroke #39

Open
evilC opened this issue Jun 10, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@evilC
Copy link
Owner

evilC commented Jun 10, 2019

There is only one block variable, causing the whole stroke to either be blocked or not.
A stroke can contain one or more of mouse button events, relative movement or absolute movement, but an if/else is used, so only one type of input will be processed per stroke

This causes the following issues:

  • When subscribing using block to mouse movement, mouse buttons are blocked, and vice versa
  • If multiple mouse buttons are subscribed, but eg only one is blocked, then all will be blocked

Each stroke needs to be split up into multiple strokes, and the if/else changed to multiple unrelated ifs

@evilC evilC added the bug Something isn't working label Jun 10, 2019
@evilC evilC changed the title When subscribing to mouse movement, mouse buttons are blocked Stroke is either wholly blocked or not blocked Jun 10, 2019
@evilC evilC changed the title Stroke is either wholly blocked or not blocked Stroke is either wholly blocked or not blocked, and only one type of input is processed per stroke Jun 10, 2019
evilC added a commit that referenced this issue Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant