Add InputMap component
#1951
Add InputMap component
#1951
Conversation
🦋 Changeset detectedLatest commit: 348d339 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for next-docs-evidence ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for evidence-development-workspace ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I will be happy if you support also the other geometry types like lines, polygons, multi-geometry. |
| function leafletAction(el, data) { | ||
| const actionPromise = asyncLeafletAction(el, data); | ||
|
|
||
| return { | ||
| destroy() { | ||
| actionPromise.then((action) => action.destroy()); | ||
| }, | ||
| update(newData) { | ||
| actionPromise.then((action) => action.update(newData)); | ||
| } | ||
| }; | ||
| } |
There was a problem hiding this comment.
Stylistic choice but I think this should go in it's own file
There was a problem hiding this comment.
I'm not really a fan of it going in a separate file - all the captured variables have to be forwarded in, which gets ugly
|
This is awesome! I think we should hold this one until we've got a final syntax we want to use for maps, and release it all at once. There's features for choropleths and tooltips I want to pull in from a custom prototype I've got, so I'll bring those changes into here |
Description
Adapts
@evidence-dev/labsLeafletMapcomponent into anInputMapcomponentChecklist