Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Alliances Based on Valid Tokens #883

Open
eeverett91 opened this issue Feb 27, 2023 · 3 comments
Open

Limit Alliances Based on Valid Tokens #883

eeverett91 opened this issue Feb 27, 2023 · 3 comments

Comments

@eeverett91
Copy link

  • Problem: Whats wrong?
    Alliances are automatically populated into SeAT based on publicly accessible information. This is different behavior from corporations (which are only loaded when a valid token is entered). Since the alliances don't have valid tokens it results in thousands of alliances which provide little to no value to see in the UI.

  • Expected: What did you expect to happen?
    Have consistent behavior between corporations and alliances. Only populate alliances which have a valid token entered, either as default behavior or via setting.

  • Logs / Screenshots / Proof: The more information you give the better!
    https://i.imgur.com/TzZVvs2.png

  • Version Info: PHP Version, SeAT Version, Operating System etc.
    SeAT API v4.9.0
    SeAT Console v4.8.0
    SeAT Eve API v4.18.1
    SeAT Notifications v4.3.3
    SeAT Services v4.2.1
    SeAT Web v4.19.3

@recursivetree
Copy link

I don't see the issue with having all alliances loaded into seat. If seat doesn't know a particular alliance, it will shows as something like "Unknown" instead of the name.

I agree that it clutters the alliance list tho. Maybe we could order it in a way that the alliances with tokens are first.

@eeverett91
Copy link
Author

Agreed, I don't see any concern with having them in the database so they can be referenced and displayed when appropriate but it'd be ideal to not have them clutter the alliances list.

I believe that's how corporations are working currently. For example, I can reference many corporations under Role Authorization Filters but I don't see them in the corporation list.

@warlof
Copy link
Member

warlof commented Feb 28, 2023

Regarding name, blades are based on either info sheet or uniname. So, if we're running in a flow which do not require a sheet, we can use the uniname (already what's done btw)

However, you talked about authorization filters, and I wonder if it's not exactly the reason why we load the complete alliance list.

When seeding alliance, we should seed uniname - and seed alliance sheet only for valid tokens maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants