Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character with inactive token not showing alts #856

Open
kwazulueve opened this issue Jan 21, 2022 · 8 comments
Open

Character with inactive token not showing alts #856

kwazulueve opened this issue Jan 21, 2022 · 8 comments
Labels
core/data Things tied to database structure discussion modules/characters Stuff related to characters ux/ui Things related to interface and user experience

Comments

@kwazulueve
Copy link

On the character sheet (characters//sheet) of a character with an inactive token the other characters of that user are not listed. This is annoying as when you click through from the corporations//tracking page on characters with an inactive token, additional searches need to be done on the user list to actually see who the main character is.

Reverse, the inactive token character(s) do get shown on any alt character sheet page

| Vendor   | Package Name           | Installed Version        |
| -------- | ---------------------- | ------------------------ |
| eveseat  | api                    | 4.7.0                    |
| eveseat  | console                | 4.8.0                    |
| eveseat  | eveapi                 | 4.16.0                   |
| eveseat  | notifications          | 4.3.1                    |
| eveseat  | services               | 4.2.0                    |
| eveseat  | web                    | 4.17.0                   |
| denngarr | seat-fitting           | 4.0.5                    |
| denngarr | seat-srp               | 4.2.6                    |
| warlof   | seat-connector         | 2.3.0                    |
| warlof   | seat-discord-connector | 5.0.0                    |
| ccp      | eve_online_sde         | sde-20211207-TRANQUILITY |
@SimplyUnnamed
Copy link

there is a permission to do this under 'global'.

'Grant access to see invalidated tokens'

@kwazulueve
Copy link
Author

I am logged in as Administrator. The issue is the linking, not not being able to see characters sheets of inactive tokens

@warlof
Copy link
Member

warlof commented Jan 23, 2022

@kwazulueve the thing is - we know to which user a character is tied based on token.
If the token is non longer valid - we non longer have the information - and might render invalid information.

You can still get access to this information on user card for a different reason : the user scope. As administrator, you might be faced to case when user duplicate user accounts and then had to forward character accross user account. This is more for administrative purpose than intel.

@kwazulueve
Copy link
Author

What is your current use case for a random member having an inactive token on an alt due to password change, a corp manager noticing that and wanting to contact said member to fix the issue?
Is there any option in Seat to deal with this either with notifications or anything atm that is not a hassle?

@warlof
Copy link
Member

warlof commented Jan 24, 2022

Hum, I would say corporation tracking ?

@warlof warlof added discussion ux/ui Things related to interface and user experience modules/characters Stuff related to characters core/data Things tied to database structure labels Jun 8, 2022
@Sjolus
Copy link

Sjolus commented Nov 2, 2023

@kwazulueve the thing is - we know to which user a character is tied based on token. If the token is non longer valid - we non longer have the information - and might render invalid information.

You can still get access to this information on user card for a different reason : the user scope. As administrator, you might be faced to case when user duplicate user accounts and then had to forward character accross user account. This is more for administrative purpose than intel.

Personally I would still prefer this way, as the user list is very inaccessible for this kind of workflow, and I don't really want to allow access to the Users page to my HR that does cleanup when someone leaves the corp. My problematic scenario is the following:

  1. Player registers his main and multiple alts
  2. Player plays in corp for a while
  3. Player decides to leave corp, but wants to sneakily leave an alt in the corporation
  4. Player revokes ESI scopes to SeAT from all characters from their 3rd party applications page
  5. We get confused, since when scopes are pulled, we can no longer see the alts associated with the main easily
  6. We end up with alts in corp that we have no knowledge over
  7. We do a deep dive and figure out where the alts belong, which of course isn't long, but could be made a lot easier if the alt <-> main connection that is shown on the could be kept even though scopes are revoked

This is important when reviewing the main of an old member to verify that their alts are no longer in the corporation, as well as when reviewing the page of an alt where the scopes have been lost (found via the tracking tab on the corporation page) to identify which player it "should" belong to.

When we get note of someone leaving (they don't always tell us, and we don't get any notifications that are actionable in SeAT when a character leaves the corporation) we would prefer to go to their main character and see the list of associated alts. If they have pulled scopes, this is not possible.

I understand the edge case of transferred characters, but it's still worthwhile seeing "this alt last belonged to main X when we last had scopes for it"

@recursivetree
Copy link

eveseat/web#657 should fix this. The problem is actually much simpler than I expected since refresh_tokens are soft deleted, sorry @Sjolus for having you open an issue

@kwazulueve
Copy link
Author

I am glad you found a fix for this pretty major usability issue, looking forward to deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core/data Things tied to database structure discussion modules/characters Stuff related to characters ux/ui Things related to interface and user experience
Projects
None yet
Development

No branches or pull requests

5 participants