Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix page/list command not showing received pages #3529

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix page/list command not showing received pages #3529

wants to merge 1 commit into from

Conversation

chiizujin
Copy link
Contributor

@chiizujin chiizujin commented May 1, 2024 •
edited

Brief overview of PR changes/additions

Fixes the page/list command not showing received pages. Resolves #3528.

Also re-words the "You haven't paged anyone yet." message to something more appropriate.

Note that this only applies to legacy pages (i.e. those with no locks at all, which would already be showing correctly) and pages sent after this fix. It does not fix existing pages with locks that do not include the receiver.

Motivation for adding to Evennia

Bug fix.

Other info

Before:

Player account 'Lancelot'.

page
You haven't paged anyone yet.

Account Chiizujin pages: What is your favourite colour?

>page
You haven't paged anyone yet.

>page chiizujin Blue.
You paged Chiizujin with: 'Blue.'.
>page
Your latest pages:
 06:23:19 to Chiizujin:> Blue.

After:

>page
You haven't sent or received any pages yet.

Account Chiizujin pages: What is your favourite colour?

>page
Your latest pages:
 06:26:35 from Chiizujin:< What is your favourite colour?

>page chiizujin Blue.
You paged Chiizujin with: 'Blue.'.
>page
Your latest pages:
 06:26:35 from Chiizujin:< What is your favourite colour?
 06:27:24 to Chiizujin:> Blue.

@chiizujin chiizujin mentioned this pull request May 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] The page/list command only shows you pages you have sent
1 participant
@chiizujin