Minor ortography fixes #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and ‘app publisher’ because they are not defined terms.
…se it should be a defined term.
…avour of the latter because that was more prevalent ortography in the documents.
skounis
approved these changes
Mar 11, 2024
duviner
approved these changes
Mar 11, 2024
|
I pushed some additional orthography fixes. Should I create a new pull request or keep the commits in this one? One of the added fixes is in |
|
Process wise the review already started so new commits will make it more difficult. On top of this the PR has already approved by two reviewers before the new commits. However I checked the commits one by one and my positive vote remains unchanged ;-) |
|
Okay, thank you for your patience. I am sorry that I deviated from the process. I should have asked first before pushing new commits. |
paolo-de-rosa
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor ortography fixes for the ARF and the annexes. Fixes are split into multiple commits and each commit has an explanatory comment.
One of the changes is in
docs/media/image7.svg(replaced ‘EUDI Wallet instance’ with ‘EUDI Wallet Instance’). It looks like the related filedocs/media/image7.pngalready has the latter ortography and thus no changes for that file is needed.