From f08d3e105c556451abfc6e0f7dfa135e63a62aeb Mon Sep 17 00:00:00 2001 From: Jason Milldrum Date: Fri, 24 Mar 2017 10:31:12 -0700 Subject: [PATCH 1/2] Fix regression in set_freq() that wiped out proper r_div setting --- README.md | 4 ++++ library.properties | 2 +- src/si5351.cpp | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 4a2af77..ac4a8d4 100644 --- a/README.md +++ b/README.md @@ -663,6 +663,10 @@ This library does not currently support the spread spectrum function of the Si53 Changelog --------- +* v2.0.3 + + * Fix regression in _set_freq()_ that wiped out proper R div setting, causing errors in setting low frequency outputs + * v2.0.2 * Increase maximum frequency in _set_freq()_ to 225 MHz diff --git a/library.properties b/library.properties index 18ea5af..9e1fa82 100644 --- a/library.properties +++ b/library.properties @@ -1,5 +1,5 @@ name=Etherkit Si5351 -version=2.0.2 +version=2.0.3 author=Jason Milldrum maintainer=Jason Milldrum sentence=A full-featured library for the Si5351 series of clock generator ICs from Silicon Labs diff --git a/src/si5351.cpp b/src/si5351.cpp index 51c5c91..ba7cd08 100644 --- a/src/si5351.cpp +++ b/src/si5351.cpp @@ -282,6 +282,7 @@ uint8_t Si5351::set_freq(uint64_t freq, enum si5351_clock clk) } else { + //uint64_t temp_freq = freq; clk_freq[(uint8_t)clk] = freq; // Enable the output @@ -302,7 +303,6 @@ uint8_t Si5351::set_freq(uint64_t freq, enum si5351_clock clk) // Set multisynth registers set_ms(clk, ms_reg, int_mode, r_div, div_by_4); - ms_div(clk, 0, 0); // Reset the PLL pll_reset(pll_assignment[clk]); From d3f2ed9aa50050a71bb717dce205fa4f6a330572 Mon Sep 17 00:00:00 2001 From: Jason Milldrum Date: Fri, 24 Mar 2017 10:33:29 -0700 Subject: [PATCH 2/2] Fix regression in set_freq() that wiped out proper r_div setting --- src/si5351.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/si5351.cpp b/src/si5351.cpp index ba7cd08..9347551 100644 --- a/src/si5351.cpp +++ b/src/si5351.cpp @@ -282,7 +282,6 @@ uint8_t Si5351::set_freq(uint64_t freq, enum si5351_clock clk) } else { - //uint64_t temp_freq = freq; clk_freq[(uint8_t)clk] = freq; // Enable the output