[Bug]: "Accumulated Rewards" value is growing after the risk bundle was burned

[rapidddenis]

What happened?

As a DIP staker I expect my rewards are accumulating only while risk bundle is active

What operating system are you seeing the problem on?

Mac OS

What browsers are you seeing the problem on?

Safari

What wallet extension are you using?

Metamask

Rules

• I agree to follow this project's rules

[doerfli]

this could happen if the bundle was burned before expiration. but the value can never be collected (as it is calculated only for display and the state is not taken into account).

https://github.com/etherisc/gif-staking-ui/blob/develop/src/backend/staking_contract.ts#L210

[rapidddenis]

It is possible to accumulate and collect after the bundle was burned: etherisc/depeg-contracts#31

[doerfli]

needs to be in sync with solution for etherisc/depeg-contracts#31

[susanneetherisc]

Is this a duplicate of #31? @doerfli will look into when back from leave

[doerfli]

No, this is not a duplicate, but it depends on the outcome of etherisc/depeg-contracts#31 to determine if the current behavior of the webapp needs to change.