Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle content keys better #516

Open
acolytec3 opened this issue Nov 13, 2023 · 1 comment
Open

Handle content keys better #516

acolytec3 opened this issue Nov 13, 2023 · 1 comment

Comments

@acolytec3
Copy link
Collaborator

As I was finishing up #514, I noticed that we do a lot of toHexString and fromHexString, specifically around the content key, both the containerized version of it with a content type as a prefix and without. We should clean up this usage so we don't do lots of unnecessary string conversions. A good example is here and the subsequent calls interior to store.
@acolytec3
Copy link
Collaborator Author

#537 should partially fix this. It at least deals with the ContentAdded message redundancies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acolytec3