Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generally improve logging #490

Open
5 tasks
acolytec3 opened this issue Oct 26, 2023 · 0 comments
Open
5 tasks

Generally improve logging #490

acolytec3 opened this issue Oct 26, 2023 · 0 comments

Comments

@acolytec3
Copy link
Collaborator

acolytec3 commented Oct 26, 2023

Todos for cleaning up logging

  • Put all logging behind a debug flag so it only prints if an environmental variable DEBUG is set
  • Have the enableLog calls in CLI (and wherever else applicable) check for an environmental DEBUG variable for setting topics
  • Update the shortId handler to accept an optional routing table variable along with the nodeId so it can lookup the ENR without having to always retrieve an ENR
  • Update all calls to shortId to ensure we add the c key if it exists (so we can identify the type of node we're interacting with)
  • Review all of the logging topics and see if we can add more descriptive logging about various protocol behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant