Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages.json needs to contain all the used packages #179

Open
omardiaa opened this issue Oct 21, 2022 · 1 comment
Open

Packages.json needs to contain all the used packages #179

omardiaa opened this issue Oct 21, 2022 · 1 comment

Comments

@omardiaa
Copy link

The following packages were not installed when I tried to install ethereumjs-wallet into my project:

  • stream
  • assert
  • buffer
  • crypto

Suggested change:
Add the following to packages.json inside dependencies:
"dependencies": {
"assert": "^2.0.0",
"buffer": "^6.0.3",
"crypto": "^1.0.1",
"stream": "^0.0.2"
}

@acolytec3
Copy link
Collaborator

Are you using this in browser? Those look like polyfills for NodeJS builtin modules used by this library and we wouldn't include those in our package.json since this library doesn't currently provide a browser-specific build (though not to say we can't explore that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants