client: update multiaddr dep #3384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrocheleau
added
PR state: needs review
dependencies
acolytec3
reviewed
Apr 29, 2024
packages/devp2p/src/dns/enr.ts
Outdated
| @@ -30,6 +22,13 @@ type ENRTreeValues = { | |||
| domain: string | |||
| } | |||
|
|
|||
| // Copied over from the multiaddr repo: https://github.com/multiformats/js-multiaddr/blob/main/src/convert.ts | |||
| // TODO: Can we import this directly from the multiaddr repo? Doing so makes CI fail | |||
There was a problem hiding this comment.
You can import the convert method from import { convert } from '@multiformats/multiaddr/convert (since multiaddr now uses an exports map in package.json) but I'm all for reducing our exposure to upstream dependencies, especially when it's for a 3 line helper. Will suggest we just remove this TODO and move forward
There was a problem hiding this comment.
I did try doing that but it seemed to error in the CI still, anyhow I agree that removing the dep altogether is better.
acolytec3
force-pushed
the
client/update-multiaddr
branch
from
483f16c
to
0fad9ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to the latest multiaddr version.
Resolves #3370