Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseSignature - fix no args case #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Nov 11, 2016

Fixes #35

@danjm
Copy link

danjm commented Jun 3, 2019

The problem that this solves went away with #72

As that PR indicates, it may not be an optimal solution. This may also add better support for return arguments.

I need to do some manual testing and perhaps add some more unit tests, and then can make a call on whether the existing solution should be replaced by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parseSignature breaks on zero input params
3 participants