Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prune flag as an external API #94

Open
carver opened this issue Aug 23, 2019 · 0 comments
Open

Remove prune flag as an external API #94

carver opened this issue Aug 23, 2019 · 0 comments

Comments

@carver
Copy link
Contributor

carver commented Aug 23, 2019

It's too easy to screw up handling of pruning when you use it directly. We should direct everyone to use the squash_changes() API instead. Let's remove the prune keyword from init, and add some internal-only API to enable pruning from within squash_changes.

It seems this needs to go into a major version bump

It's possible that we might be able to hide away the prune keyword somehow and force squash_changes as the only approach to do that. I think we could cover both use cases that way, but I'm not sure how it would look to launch a pruning trie from inside squash_changes() (which uses the prune keyword internally right now).

Originally posted by @carver in #93 (comment)

pacrob added a commit to pacrob/py-trie that referenced this issue May 12, 2023
change references to doc to all be docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant