Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to a namespace package architecture #2081

Open
skellet0r opened this issue Sep 15, 2022 · 1 comment
Open

Transition to a namespace package architecture #2081

skellet0r opened this issue Sep 15, 2022 · 1 comment

Comments

@skellet0r
Copy link

skellet0r commented Sep 15, 2022

What is wrong?

py-evm hogs the eth namespace, preventing other packages seeking to utilize it as well (skellet0r/eth-stdlib#1).

How can it be fixed

Rename the eth directory to evm, and place it inside of the eth namespace.

Ex.

├── src
│   └── eth
│       └── evm
│           ├── db
│           └── estimators.py
│           └── ...
│           └── __init__.py

This would be a breaking change, and downstream users, would merely have to change any imports of 'eth' to 'eth.evm', a simple grok. This is fine since py-evm has yet to even reach v1.0.0, and it's breaking changes are expected/condoned.

https://packaging.python.org/en/latest/guides/packaging-namespace-packages/

related: #1849

@fselmo
Copy link
Collaborator

fselmo commented Sep 15, 2022

Hey @skellet0r. I'd be on board with this for sure. I think as soon as we get some of the bigger changes in, we can refactor this structure before the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants