Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incrementally building clique blocks doesn't work #1961

Open
gsalgado opened this issue Nov 6, 2020 · 1 comment
Open

Incrementally building clique blocks doesn't work #1961

gsalgado opened this issue Nov 6, 2020 · 1 comment

Comments

@gsalgado
Copy link
Collaborator

gsalgado commented Nov 6, 2020

Trying to incrementally build clique blocks fails (the state root will be wrong on the final block) because the initial header is not signed so all tx fees are incorrectly assigned to the coinbase address.

@gsalgado
Copy link
Collaborator Author

gsalgado commented Nov 6, 2020

We should also probably get rid of

return header.coinbase
as it lets one incrementally build a block that in the end won't be valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant