Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+u makes an undo before upload #274

Open
baljo opened this issue Oct 20, 2022 · 4 comments
Open

Ctrl+u makes an undo before upload #274

baljo opened this issue Oct 20, 2022 · 4 comments

Comments

@baljo
Copy link

baljo commented Oct 20, 2022

Ctrl+u makes an undo before upload, is it a feature or a bug or something I'm misunderstanding? To avoid the undoing I need to move the cursor to another line first which I tend to forget. Same happens if you select all (Ctrl+a), then Ctrl+v to paste in some other code and Ctrl+u to upload.
In Arduino IDE Ctrl+u also does an upload, but no undo before.

@gfwilliams
Copy link
Member

Is it possible that you had changed the JavaScript Editor Keymap to something other than 'sublime'?

@baljo
Copy link
Author

baljo commented Oct 21, 2022

I checked, but it's 'sublime'. Btw, same happens on the two Win10-computers I use.

@gfwilliams
Copy link
Member

Ahh, thanks! maybe it's windows related as I can't reproduce here on Linux.

I just checked the code and we definitely call e.preventDefault(); on the keydown event so you'd hope it would be handled, but maybe we also need to handle the keypress event

@baljo
Copy link
Author

baljo commented Oct 26, 2022

Don't know if it's of some help, but same issue regardless of if I'm using the browser-based or the native IDE. As browser I'm using the latest Chrome: Version 106.0.5249.119 (Official Build) (64-bit)
Edit: Chrome got updated to Version 107.0.5304.63 (Official Build) (64-bit), the issue is no longer happening in the Web-IDE, just in the native app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants