Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backswipe/messagegui] Can't blacklist messagegui.new.js #3388

Closed
thyttan opened this issue Apr 29, 2024 · 1 comment · Fixed by #3391
Closed

[backswipe/messagegui] Can't blacklist messagegui.new.js #3388

thyttan opened this issue Apr 29, 2024 · 1 comment · Fixed by #3391

Comments

@thyttan
Copy link
Collaborator

thyttan commented Apr 29, 2024

Affected hardware version

Bangle 2

Your firmware version

2v21.107

The bug

I have blacklisted messagegui from backswipe (messages in backswipe settings menu) and it works to stop backswipe action if I open messagegui manually. If a new message is opened automatically the blacklisting doesn't take affect. Presumably because of the filename being different than backswipe expects.

Reproduce:

  1. install messagegui
  2. install and set up backswipe, adding "messages" to blacklist in backswipe settings.
  3. exit to clock face.
  4. receive a message that automatically opens on the watch (e.g. debug message from Gadgetbridge)
  5. do backswipe motion on the opened message and notice it wasn't blacklisted properly.

Possible solution:
Maybe instead of checking whether the __FILE__-name is same as in src it should see if __FILE__ is in the string in files of the info file. But the refactor maybe isn't as straight forward as I initially felt here.

Installed apps

messageicons (0.07)
messagegui (0.79)
widmessages (0.06)
messages (0.62)
widmsggrid (0.06)
notify (0.13)
health (0.30)
widminbate (0.05)
podadrem (0.10)
spotrem (0.11)
android (0.34)
lightswitch (0.10)
widanclk (0.03)
backswipe (0.03)
torch (0.11)
calculator (0.07)
widbthide (0.01)
smpltmr (0.09)
clkinfostopw (0.03)
runplus (0.24)
dtlaunch (0.25)
quicklaunch (0.15)
kineticscroll (0.03)
widalarm (0.02)
alarm (0.47)
recorder (0.43)
bthrm (0.19)
fastload (0.06)
fastreset (0.03)
agenda (0.15)
edgeclk (0.03)
setting (0.71)
boot (0.60)
mysetup (0.02)
clockbg (0.02)
analogquadclk (0.02)
kbmulti (0.09)
sched (0.26)
clock_info (0.11)
msgwakefup (0.01)
ctrlpad (0.01)
chargent (0.07)
widChargingStatus (0.03)

@thyttan
Copy link
Collaborator Author

thyttan commented Apr 29, 2024

Tagging @Kedlub in case you'd think of a smart solution :)

edit: added a PR with a fix. Please have a look if you get the time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant