Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[messagegui] Music info lost if Auto-open messages is false (the default) #2814

Open
gfwilliams opened this issue Jun 12, 2023 · 0 comments
Open

Comments

@gfwilliams
Copy link
Member

Affected hardware version

Bangle 2

Your firmware version

2v18

The bug

To reproduce:

  • Be on clock
  • Play music on the phone (with Gadgetbridge), or paste:
GB({t:"musicinfo",artist:"No Doubt",album:"Tragic Kingdom",track:"Don't Speak",dur:263,c:-1,n:-1})
GB({t:"musicstate",state:"play",position:171,shuffle:1,repeat:1})
  • ... Nothing happens
  • Look in messages app - no messages shown
  • Stop/restart music - still no messages shown
  • Exit messages, restart messages - Music message shown in list

Now I (now) know there's a menu item called auto-open Music and setting that effectively fixes this but without it, the current behaviour feels wrong.

I've just pushes a fix which allows the messages app to show a music message if it arrives while the message app is running, but I guess I'm wondering: If we receive music info when we're on clock, then we go to messages - we should probably end up showing music in the music list?

I wonder how we fix that without writing to storage for every music update message? We have exports.music so maybe we have to have a E.on('kill handler that writes the music into the messages list on exit?

Installed apps

android,messages,messagegui,...

@gfwilliams gfwilliams added the type-bug Something isn't working label Jun 12, 2023
gfwilliams added a commit that referenced this issue Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants