Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code mixes tabs and spaces #518

Open
mtfurlan opened this issue Jun 21, 2022 · 3 comments
Open

Code mixes tabs and spaces #518

mtfurlan opened this issue Jun 21, 2022 · 3 comments

Comments

@mtfurlan
Copy link

I noticed that there is a mix of tabs and spaces.
I'm happy to make a PR to clean that up, but which way should it go?
I would personally prefer spaces, but I'll make it consistent either way.

@omersiar
Copy link
Collaborator

Hello,

Spaces are nice 😊 .

@mtfurlan
Copy link
Author

What about

if (stuff)
{
    ...
}

vs

if (stuff) {
    ...
}

?
I thought there was only the former but I just found some of the latter.

Would you be interested in having an uncrustify config?

I dunno what the best way to keep the codebase in line with a config would be though.
At $work I don't allow a PR to merge if it doesn't pass an automated run of the linter, but that seems like it might be overly complicated here.

@matjack1
Copy link
Collaborator

As I mentioned here: #524 (comment) I don't mind which way you prefer, so long as it's automatically set up by VS Code and ideally in the CI, so that we cannot break it again :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants